Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(72)

Issue 17589012: Add error-page support in VirtualDirectory. (Closed)

Created:
7 years, 6 months ago by Anders Johnsen
Modified:
7 years, 6 months ago
Reviewers:
Søren Gjesse
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Add error-page support in VirtualDirectory. BUG= R=sgjesse@google.com Committed: https://code.google.com/p/dart/source/detail?r=24378

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+77 lines, -3 lines) Patch
M pkg/http_server/lib/src/virtual_directory.dart View 4 chunks +33 lines, -3 lines 0 comments Download
M pkg/http_server/test/utils.dart View 1 chunk +7 lines, -0 lines 0 comments Download
M pkg/http_server/test/virtual_directory_test.dart View 1 chunk +37 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Anders Johnsen
7 years, 6 months ago (2013-06-24 14:09:38 UTC) #1
Søren Gjesse
lgtm
7 years, 6 months ago (2013-06-24 14:55:19 UTC) #2
Anders Johnsen
7 years, 6 months ago (2013-06-25 06:00:27 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r24378 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698