Issue 17587015: Allows exception object to be null in simarm and simmips.

Issue 17587015: Allows exception object to be null in simarm and simmips. (Closed)

Created:
7 years, 6 months ago by zra

Modified:
7 years, 6 months ago

Reviewers:
regis, srdjan

CC:
reviews_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Allows exception object to be null in simarm and simmips. Also, updates status files. R=regis@google.com Committed: https://code.google.com/p/dart/source/detail?r=24361

Patch Set 2 : #

Created: 7 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+6 lines, -10 lines)			Patch
M	runtime/vm/simulator_arm.cc	View	1	1 chunk	+3 lines, -4 lines	0 comments	Download
M	runtime/vm/simulator_mips.cc	View	1	1 chunk	+3 lines, -4 lines	0 comments	Download
M	tests/co19/co19-runtime.status	View	1	2 chunks	+0 lines, -2 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

regis

LGTM https://codereview.chromium.org/17587015/diff/1/runtime/tests/vm/vm.status File runtime/tests/vm/vm.status (right): https://codereview.chromium.org/17587015/diff/1/runtime/tests/vm/vm.status#newcode58 runtime/tests/vm/vm.status:58: dart/isolate_mirror_local_test: Crash I see this crash on the ...

7 years, 6 months ago (2013-06-24 17:30:47 UTC) #2

srdjan

https://codereview.chromium.org/17587015/diff/1/runtime/tests/vm/vm.status File runtime/tests/vm/vm.status (right): https://codereview.chromium.org/17587015/diff/1/runtime/tests/vm/vm.status#newcode57 runtime/tests/vm/vm.status:57: [ $arch == simarm && $mode == release ] ...

7 years, 6 months ago (2013-06-24 18:19:43 UTC) #3

zra

Committed patchset #2 manually as r24361 (presubmit successful).

7 years, 6 months ago (2013-06-24 18:38:49 UTC) #4

zra

7 years, 6 months ago (2013-06-24 18:43:58 UTC) #5

Message was sent while issue was closed.

https://codereview.chromium.org/17587015/diff/1/runtime/tests/vm/vm.status
File runtime/tests/vm/vm.status (right):

https://codereview.chromium.org/17587015/diff/1/runtime/tests/vm/vm.status#ne...
runtime/tests/vm/vm.status:58: dart/isolate_mirror_local_test: Crash
On 2013/06/24 17:30:47, regis wrote:
> I see this crash on the buildbot. Is this unrelated to this cl? 

Yes, it's unrelated.

https://codereview.chromium.org/17587015/diff/1/runtime/vm/simulator_arm.cc
File runtime/vm/simulator_arm.cc (right):

https://codereview.chromium.org/17587015/diff/1/runtime/vm/simulator_arm.cc#n...
runtime/vm/simulator_arm.cc:3076: 
On 2013/06/24 17:30:47, regis wrote:
> My concern is that we trash register kExceptionObjectReg when no exception is
> reported, i.e. when raw_exception == NULL.
> I suggest we do the same as for raw_stacktrace, i.e. we only set
> kExceptionObjectReg when raw_exception != NULL.
> We can then wait for Florian's cl and revisit. 

raw_exception == NULL means that someone threw the Smi 0, so it is allowed.
Object::null() is not allowed here. raw_stacktrace can be anything so we pass it
through.

Expand Messages | Collapse Messages