Issue 17587006: Report CTEC.INSTANCE_MEMBER_ACCESS_FROM_STATIC

Issue 17587006: Report CTEC.INSTANCE_MEMBER_ACCESS_FROM_STATIC (Closed)

Created:
7 years, 6 months ago by scheglov

Modified:
7 years, 6 months ago

Reviewers:
jwren, Brian Wilkerson

CC:
reviews_dartlang.org, lukeechurch_gmail.com

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Report CTEC.INSTANCE_MEMBER_ACCESS_FROM_STATIC R=brianwilkerson@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=24343

Patch Set 1 #

Total comments: 2

Created: 7 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+80 lines, -10 lines)			Patch
M	editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/error/CompileTimeErrorCode.java	View	1 chunk	+6 lines, -0 lines	0 comments	Download
M	editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/verifier/ErrorVerifier.java	View	7 chunks	+20 lines, -3 lines	2 comments	Download
M	editor/tools/plugins/com.google.dart.engine_test/src/com/google/dart/engine/resolver/CompileTimeErrorCodeTest.java	View	1 chunk	+39 lines, -0 lines	0 comments	Download
M	editor/tools/plugins/com.google.dart.engine_test/src/com/google/dart/engine/resolver/NonErrorResolverTest.java	View	1 chunk	+13 lines, -0 lines	0 comments	Download
M	editor/tools/plugins/com.google.dart.engine_test/src/com/google/dart/engine/resolver/StaticWarningCodeTest.java	View	2 chunks	+2 lines, -4 lines	0 comments	Download
M	tests/co19/co19-analyzer.status	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	tests/language/language_analyzer.status	View	1 chunk	+0 lines, -2 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Brian Wilkerson

LGTM, although it might need a TODO for later work. https://codereview.chromium.org/17587006/diff/1/editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/verifier/ErrorVerifier.java File editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/verifier/ErrorVerifier.java (right): https://codereview.chromium.org/17587006/diff/1/editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/verifier/ErrorVerifier.java#newcode2530 ...

7 years, 6 months ago (2013-06-24 15:14:49 UTC) #2

scheglov

Committed patchset #1 manually as r24343 (presubmit successful).

7 years, 6 months ago (2013-06-24 16:20:56 UTC) #3

scheglov

7 years, 6 months ago (2013-06-24 16:21:29 UTC) #4

Message was sent while issue was closed.

https://codereview.chromium.org/17587006/diff/1/editor/tools/plugins/com.goog...
File
editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/verifier/ErrorVerifier.java
(right):

https://codereview.chromium.org/17587006/diff/1/editor/tools/plugins/com.goog...
editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/verifier/ErrorVerifier.java:2530:
if (!isInConstructorInitializer && !isInStaticMethod) {
On 2013/06/24 15:14:49, Brian Wilkerson wrote:
> What about references in a static field initializer?

I will add TODO.

Expand Messages | Collapse Messages