Report CompileTimeErrorCode.INSTANCE_STATIC_MEMBER

Report CompileTimeErrorCode.INSTANCE_STATIC_MEMBER

R=brianwilkerson@google.com, jwren@google.com
BUG=

Committed: https://code.google.com/p/dart/source/detail?r=24353

[Brian Wilkerson, 2013-06-24 14:06:11]

LGTM, but you should get Jaime's input before committing.

https://codereview.chromium.org/17587004/diff/1/editor/tools/plugins/com.goog...
File
editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/verifier/ErrorVerifier.java
(right):

https://codereview.chromium.org/17587004/diff/1/editor/tools/plugins/com.goog...
editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/verifier/ErrorVerifier.java:2738:
private boolean checkForInstanceStaticMembers() {
Do we need to do the inverse: check for instance members that have the same name
as an overridden static member?

Does this duplicate other errors? I seem to recall that we are suppose to
produce an error if a method and a getter have the same name. If one is an
instance member and the other is static, do we end up with two errors? If so, I
think we should only produce one (and I'm leaning toward the error about having
two kinds of members having the same name).

[jwren, 2013-06-24 17:03:03]

LGTM.

In this CL (or a follow on CL) we should rename the error code
"DUPLICATE_MEMBER_NAME_INHERITANCE", also in the description we should indicate
that it is a duplicate name via the inherited class.  If you want, since I am
cleaning up some of the DUPLICATE_* codes already, commit it as-is- I don't mind
changing the error code/ description.

(More context.) The part of the spec that you included in the description for
the error code matches a description from DUPLICATE_MEMBER_NAME_INSTANCE_STATIC.
 This CL however (DUPLICATE_MEMBER_NAME_INSTANCE_STATIC) I am currently folding
in DUPLICATE_MEMBER_NAME- so don't just use
DUPLICATE_MEMBER_NAME_INSTANCE_STATIC.

Great CL though, hadn't made it to this case yet.  This is why it is so handy to
have the co19 and language tests!

[scheglov, 2013-06-24 17:35:48]

Jaime, I will  commit this CL as is and let you to continue your work on
improving names and messages (which you obviously can do better than I :-)).

https://codereview.chromium.org/17587004/diff/1/editor/tools/plugins/com.goog...
File
editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/verifier/ErrorVerifier.java
(right):

https://codereview.chromium.org/17587004/diff/1/editor/tools/plugins/com.goog...
editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/verifier/ErrorVerifier.java:2738:
private boolean checkForInstanceStaticMembers() {
On 2013/06/24 14:06:11, Brian Wilkerson wrote:
> Do we need to do the inverse: check for instance members that have the same
name
> as an overridden static member?

  I'm not sure what do you mean under "overridden static member".
  Static members are not inherited.
  We do have such warning already.


> Does this duplicate other errors? I seem to recall that we are suppose to
> produce an error if a method and a getter have the same name. If one is an
> instance member and the other is static, do we end up with two errors? If so,
I
> think we should only produce one (and I'm leaning toward the error about
having
> two kinds of members having the same name).

AFAIK it is error to *declare* two members with the same name, but it is not (in
general) to *have* them.
Here we refine "to have" case. And we look into inherited members, so don't
duplicate errors.

[scheglov, 2013-06-24 17:36:23]

Committed patchset #1 manually as r24353 (presubmit successful).