Issue 17583019: Don't report INVOCATION_OF_NON_FUNCTION if variable is dynamic

Issue 17583019: Don't report INVOCATION_OF_NON_FUNCTION if variable is dynamic (Closed)

Created:
7 years, 6 months ago by scheglov

Modified:
7 years, 6 months ago

Reviewers:
jwren, Brian Wilkerson

CC:
reviews_dartlang.org, lukeechurch_gmail.com

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Don't report INVOCATION_OF_NON_FUNCTION if variable is dynamic R=brianwilkerson@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=24425

Patch Set 2 : Don't use propagated type in this case #

Created: 7 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+26 lines, -6 lines)			Patch
M	editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/resolver/ElementResolver.java	View	1	1 chunk	+1 line, -4 lines	0 comments	Download
M	editor/tools/plugins/com.google.dart.engine_test/src/com/google/dart/engine/resolver/NonErrorResolverTest.java	View	1	1 chunk	+25 lines, -0 lines	0 comments	Download
M	tests/co19/co19-analyzer.status	View	1	1 chunk	+0 lines, -2 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

Brian Wilkerson

https://codereview.chromium.org/17583019/diff/1/editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/resolver/ElementResolver.java File editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/resolver/ElementResolver.java (right): https://codereview.chromium.org/17583019/diff/1/editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/resolver/ElementResolver.java#newcode1214 editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/resolver/ElementResolver.java:1214: Type variablePropagatedType = resolver.getOverrideManager().getType(element); I'm not sure why we're ...

7 years, 6 months ago (2013-06-25 13:54:41 UTC) #2

scheglov

PTAL https://codereview.chromium.org/17583019/diff/1/editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/resolver/ElementResolver.java File editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/resolver/ElementResolver.java (right): https://codereview.chromium.org/17583019/diff/1/editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/resolver/ElementResolver.java#newcode1214 editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/resolver/ElementResolver.java:1214: Type variablePropagatedType = resolver.getOverrideManager().getType(element); On 2013/06/25 13:54:42, Brian ...

7 years, 6 months ago (2013-06-25 18:14:09 UTC) #3

scheglov

7 years, 6 months ago (2013-06-25 18:20:23 UTC) #5

Message was sent while issue was closed.

Committed patchset #2 manually as r24425 (presubmit successful).

Expand Messages | Collapse Messages