Issue 17583007: Fix issue 11398 by making sure we look at mixin applications

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 17583007: Fix issue 11398 by making sure we look at mixin applications (Closed)

Created:
7 years, 6 months ago by kasperl

Modified:
7 years, 6 months ago

Reviewers:
ngeoffray

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Fix issue 11398 by making sure we look at mixin applications when trying to figure out if an element can be hit with a typed selector. R=ngeoffray@google.com BUG=http://dartbug.com/11398 Committed: https://code.google.com/p/dart/source/detail?r=24315

Patch Set 1 #

Total comments: 2

Created: 7 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+53 lines, -3 lines)			Patch
	M	sdk/lib/_internal/compiler/implementation/types/flat_type_mask.dart	View		1 chunk	+10 lines, -3 lines	2 comments	Download
	A	tests/language/mixin_regress_11398_test.dart	View		1 chunk	+43 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

ngeoffray

LGTM! https://codereview.chromium.org/17583007/diff/1/sdk/lib/_internal/compiler/implementation/types/flat_type_mask.dart File sdk/lib/_internal/compiler/implementation/types/flat_type_mask.dart (right): https://codereview.chromium.org/17583007/diff/1/sdk/lib/_internal/compiler/implementation/types/flat_type_mask.dart#newcode442 sdk/lib/_internal/compiler/implementation/types/flat_type_mask.dart:442: || other.isSubclassOf(mixinApplication) indent one more? https://codereview.chromium.org/17583007/diff/1/sdk/lib/_internal/compiler/implementation/types/flat_type_mask.dart#newcode443 sdk/lib/_internal/compiler/implementation/types/flat_type_mask.dart:443: || ...

7 years, 6 months ago (2013-06-24 08:59:05 UTC) #2

kasperl

7 years, 6 months ago (2013-06-24 09:27:46 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as r24315 (presubmit successful).

Expand Messages | Collapse Messages