Issue 17583005: Report CONST_EVAL_TYPE_BOOL when left operand of || is 'true'.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 17583005: Report CONST_EVAL_TYPE_BOOL when left operand of || is 'true'. (Closed)

Created:
7 years, 6 months ago by scheglov

Modified:
7 years, 6 months ago

Reviewers:
jwren, Brian Wilkerson

CC:
reviews_dartlang.org, lukeechurch_gmail.com

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

Report CONST_EVAL_TYPE_BOOL when left operand of || is 'true'. R=brianwilkerson@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=24340

Created: 7 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+11 lines, -5 lines)			Patch
M	editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/constant/ValidResult.java	View	1 chunk	+4 lines, -4 lines	0 comments	Download
M	editor/tools/plugins/com.google.dart.engine_test/src/com/google/dart/engine/resolver/CompileTimeErrorCodeTest.java	View	1 chunk	+7 lines, -0 lines	0 comments	Download
M	tests/co19/co19-analyzer.status	View	1 chunk	+0 lines, -1 line	0 comments	Download

Total messages: 4 (0 generated)

scheglov

Committed patchset #1 manually as r24340 (presubmit successful).

7 years, 6 months ago (2013-06-24 16:06:26 UTC) #3

jwren

7 years, 6 months ago (2013-06-24 16:50:47 UTC) #4

Message was sent while issue was closed.

On 2013/06/24 16:06:26, scheglov wrote:
> Committed patchset #1 manually as r24340 (presubmit successful).

LGTM