Issue 17582016: Convert implementation in mirrors.cc to use Dart_GetType instead of Dart_GetClass.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 17582016: Convert implementation in mirrors.cc to use Dart_GetType instead of Dart_GetClass. (Closed)

Created:
7 years, 6 months ago by siva

Modified:
7 years, 6 months ago

Reviewers:
regis

CC:
reviews_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Convert implementation in mirrors.cc to use Dart_GetType instead of Dart_GetClass. R=regis@google.com Committed: https://code.google.com/p/dart/source/detail?r=24491

Patch Set 5 : #

Created: 7 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+176 lines, -142 lines)			Patch
M	runtime/lib/mirrors.cc	View	1 2 3 4	29 chunks	+88 lines, -88 lines	0 comments	Download
M	runtime/vm/dart_api_impl_test.cc	View	1 2 3 4	1 chunk	+2 lines, -2 lines	0 comments	Download
M	runtime/vm/mirrors_api_impl.cc	View	1 2 3 4	11 chunks	+86 lines, -52 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

regis

LGTM https://codereview.chromium.org/17582016/diff/8001/runtime/lib/mirrors.cc File runtime/lib/mirrors.cc (right): https://codereview.chromium.org/17582016/diff/8001/runtime/lib/mirrors.cc#newcode48 runtime/lib/mirrors.cc:48: static Dart_Handle MapNew() { Probably not for this ...

7 years, 6 months ago (2013-06-26 00:16:05 UTC) #2

siva

https://codereview.chromium.org/17582016/diff/8001/runtime/lib/mirrors.cc File runtime/lib/mirrors.cc (right): https://codereview.chromium.org/17582016/diff/8001/runtime/lib/mirrors.cc#newcode48 runtime/lib/mirrors.cc:48: static Dart_Handle MapNew() { Some or all of this ...

7 years, 6 months ago (2013-06-26 21:27:14 UTC) #3

siva

7 years, 6 months ago (2013-06-26 21:30:21 UTC) #4

Message was sent while issue was closed.

Committed patchset #5 manually as r24491 (presubmit successful).

Expand Messages | Collapse Messages

Issue 17582016: Convert implementation in mirrors.cc to use Dart_GetType instead of Dart_GetClass. (Closed)

Description

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Patch Set 5 : #

Messages