Add a new MIME-type package 'mime', with implementation for handling mime-type lookup by path (fine…

Add a new MIME-type package 'mime', with implementation for handling mime-type lookup by path (finename extension) and magic-number matching.

BUG=
R=sgjesse@google.com

Committed: https://code.google.com/p/dart/source/detail?r=24324

[Søren Gjesse, 2013-06-24 11:02:55]

lgtm

https://codereview.chromium.org/17582009/diff/1/pkg/mime/lib/src/extension_ma...
File pkg/mime/lib/src/extension_map.dart (right):

https://codereview.chromium.org/17582009/diff/1/pkg/mime/lib/src/extension_ma...
pkg/mime/lib/src/extension_map.dart:8: Map<String, String> _defaultExtensionMap
= const <String, String>{
It would be faster and to make this a sorted list and then use binary search.
The extensions seems to be already sorted. A test can be added to ensure that it
stays sorted when updated.

https://codereview.chromium.org/17582009/diff/1/pkg/mime/lib/src/magic_number...
File pkg/mime/lib/src/magic_number.dart (right):

https://codereview.chromium.org/17582009/diff/1/pkg/mime/lib/src/magic_number...
pkg/mime/lib/src/magic_number.dart:43: mask: const [1, 1, 1, 0, 1, 1, 1, 1, 1,
1, 1, 1])
Shouldn't the mask be a bit-mask [OxFF, OxFF, ....]?

https://codereview.chromium.org/17582009/diff/1/pkg/mime/lib/src/mime_type.dart
File pkg/mime/lib/src/mime_type.dart (right):

https://codereview.chromium.org/17582009/diff/1/pkg/mime/lib/src/mime_type.da...
pkg/mime/lib/src/mime_type.dart:12: * the default extension map.
What happens if the extension is not found?

https://codereview.chromium.org/17582009/diff/1/pkg/mime/lib/src/mime_type.da...
pkg/mime/lib/src/mime_type.dart:16: * a file have been saved using the wrong
file-name extension.
Please add some information on the number of bytes required. What happens if to
few bytes are supplied?

https://codereview.chromium.org/17582009/diff/1/pkg/mime/lib/src/mime_type.da...
pkg/mime/lib/src/mime_type.dart:18: String lookupMimeType(String path,
How about moving this to a static method on the MimeTypeResolver class?

https://codereview.chromium.org/17582009/diff/1/pkg/mime/lib/src/mime_type.da...
pkg/mime/lib/src/mime_type.dart:26: class MimeTypeResolver {
Maybe add static getter for the global resolver.

[Anders Johnsen, 2013-06-24 11:22:19]

Adding some better testing.

https://codereview.chromium.org/17582009/diff/1/pkg/mime/lib/src/extension_ma...
File pkg/mime/lib/src/extension_map.dart (right):

https://codereview.chromium.org/17582009/diff/1/pkg/mime/lib/src/extension_ma...
pkg/mime/lib/src/extension_map.dart:8: Map<String, String> _defaultExtensionMap
= const <String, String>{
On 2013/06/24 11:02:55, Søren Gjesse wrote:
> It would be faster and to make this a sorted list and then use binary search.
> The extensions seems to be already sorted. A test can be added to ensure that
it
> stays sorted when updated.

Adding TODO.

https://codereview.chromium.org/17582009/diff/1/pkg/mime/lib/src/magic_number...
File pkg/mime/lib/src/magic_number.dart (right):

https://codereview.chromium.org/17582009/diff/1/pkg/mime/lib/src/magic_number...
pkg/mime/lib/src/magic_number.dart:43: mask: const [1, 1, 1, 0, 1, 1, 1, 1, 1,
1, 1, 1])
On 2013/06/24 11:02:55, Søren Gjesse wrote:
> Shouldn't the mask be a bit-mask [OxFF, OxFF, ....]?

Done.

https://codereview.chromium.org/17582009/diff/1/pkg/mime/lib/src/mime_type.dart
File pkg/mime/lib/src/mime_type.dart (right):

https://codereview.chromium.org/17582009/diff/1/pkg/mime/lib/src/mime_type.da...
pkg/mime/lib/src/mime_type.dart:12: * the default extension map.
On 2013/06/24 11:02:55, Søren Gjesse wrote:
> What happens if the extension is not found?

Done.

https://codereview.chromium.org/17582009/diff/1/pkg/mime/lib/src/mime_type.da...
pkg/mime/lib/src/mime_type.dart:16: * a file have been saved using the wrong
file-name extension.
On 2013/06/24 11:02:55, Søren Gjesse wrote:
> Please add some information on the number of bytes required. What happens if
to
> few bytes are supplied?

Done.

https://codereview.chromium.org/17582009/diff/1/pkg/mime/lib/src/mime_type.da...
pkg/mime/lib/src/mime_type.dart:18: String lookupMimeType(String path,
On 2013/06/24 11:02:55, Søren Gjesse wrote:
> How about moving this to a static method on the MimeTypeResolver class?

I've seen from other libraries and code that people prefer simple top-level
functions for scripting.

https://codereview.chromium.org/17582009/diff/1/pkg/mime/lib/src/mime_type.da...
pkg/mime/lib/src/mime_type.dart:26: class MimeTypeResolver {
On 2013/06/24 11:02:55, Søren Gjesse wrote:
> Maybe add static getter for the global resolver.

As discussed offline, I prefer the global one to be truly static.

[Anders Johnsen, 2013-06-24 11:51:51]

Updated with much better test coverage. Landing.

[Anders Johnsen, 2013-06-24 11:55:57]

Committed patchset #4 manually as r24324 (presubmit successful).

[kasperl, 2013-06-24 13:06:43]

https://codereview.chromium.org/17582009/diff/6002/pkg/mime/lib/src/mime_type...
File pkg/mime/lib/src/mime_type.dart (right):

https://codereview.chromium.org/17582009/diff/6002/pkg/mime/lib/src/mime_type...
pkg/mime/lib/src/mime_type.dart:5: part of mime_type;
part of mime?

[Anders Johnsen, 2013-06-24 13:11:43]

https://codereview.chromium.org/17583010/

https://codereview.chromium.org/17582009/diff/6002/pkg/mime/lib/src/mime_type...
File pkg/mime/lib/src/mime_type.dart (right):

https://codereview.chromium.org/17582009/diff/6002/pkg/mime/lib/src/mime_type...
pkg/mime/lib/src/mime_type.dart:5: part of mime_type;
On 2013/06/24 13:06:43, kasperl wrote:
> part of mime?

Done.