Issue 17582002: Add support for IfModifiedSince headers, in http_servers' VirtualDirectory.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 17582002: Add support for IfModifiedSince headers, in http_servers' VirtualDirectory. (Closed)

Created:
7 years, 6 months ago by Anders Johnsen

Modified:
7 years, 6 months ago

Reviewers:
Søren Gjesse

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Add support for IfModifiedSince headers, in http_servers' VirtualDirectory. BUG= R=sgjesse@google.com Committed: https://code.google.com/p/dart/source/detail?r=24314

Patch Set 2 : Clean up tests and add TODO. #

Patch Set 3 : Merge. #

Created: 7 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+153 lines, -45 lines)			Patch
	M	pkg/http_server/lib/src/virtual_directory.dart	View	1	2 chunks	+61 lines, -1 line	0 comments	Download
	M	pkg/http_server/test/virtual_directory_test.dart	View	1 2	11 chunks	+92 lines, -44 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Anders Johnsen

This also adds ranges - something I plan to test in a future CL.

7 years, 6 months ago (2013-06-23 20:20:55 UTC) #1

Søren Gjesse

lgtm https://codereview.chromium.org/17582002/diff/1/pkg/http_server/lib/src/virtual_directory.dart File pkg/http_server/lib/src/virtual_directory.dart (right): https://codereview.chromium.org/17582002/diff/1/pkg/http_server/lib/src/virtual_directory.dart#newcode170 pkg/http_server/lib/src/virtual_directory.dart:170: file.openRead().pipe(response).catchError((_) {}); I don't think we should just ...

7 years, 6 months ago (2013-06-24 08:17:24 UTC) #2