Use the web_socket_channel package.

Use the web_socket_channel package.

R=kevmoo@google.com

Committed: https://github.com/dart-lang/shelf_web_socket/commit/2027ad0d91ee02deac98354c26a299fc75668a5a

[kevmoo, 2016-03-03 00:50:50]

LGTM

You plan to release an updated pkg/test soonish, right?

https://codereview.chromium.org/1758123002/diff/1/lib/shelf_web_socket.dart
File lib/shelf_web_socket.dart (right):

https://codereview.chromium.org/1758123002/diff/1/lib/shelf_web_socket.dart#n...
lib/shelf_web_socket.dart:5: import
'package:web_socket_channel/web_socket_channel.dart';
sorting?

https://codereview.chromium.org/1758123002/diff/1/lib/src/web_socket_handler....
File lib/src/web_socket_handler.dart (right):

https://codereview.chromium.org/1758123002/diff/1/lib/src/web_socket_handler....
lib/src/web_socket_handler.dart:7: import
'package:web_socket_channel/web_socket_channel.dart';
sorting?

https://codereview.chromium.org/1758123002/diff/1/pubspec.yaml
File pubspec.yaml (right):

https://codereview.chromium.org/1758123002/diff/1/pubspec.yaml#newcode8
pubspec.yaml:8: web_socket_channel: "^1.0.0"
sorting?

[nweiz, 2016-03-03 20:08:01]

Code review changes

[nweiz, 2016-03-03 20:08:22]

> You plan to release an updated pkg/test soonish, right?

Yes.

https://codereview.chromium.org/1758123002/diff/1/lib/shelf_web_socket.dart
File lib/shelf_web_socket.dart (right):

https://codereview.chromium.org/1758123002/diff/1/lib/shelf_web_socket.dart#n...
lib/shelf_web_socket.dart:5: import
'package:web_socket_channel/web_socket_channel.dart';
On 2016/03/03 00:50:50, kevmoo wrote:
> sorting?

Done.

https://codereview.chromium.org/1758123002/diff/1/lib/src/web_socket_handler....
File lib/src/web_socket_handler.dart (right):

https://codereview.chromium.org/1758123002/diff/1/lib/src/web_socket_handler....
lib/src/web_socket_handler.dart:7: import
'package:web_socket_channel/web_socket_channel.dart';
On 2016/03/03 00:50:50, kevmoo wrote:
> sorting?

Done.

https://codereview.chromium.org/1758123002/diff/1/pubspec.yaml
File pubspec.yaml (right):

https://codereview.chromium.org/1758123002/diff/1/pubspec.yaml#newcode8
pubspec.yaml:8: web_socket_channel: "^1.0.0"
On 2016/03/03 00:50:50, kevmoo wrote:
> sorting?

Done.

[nweiz, 2016-03-03 20:08:34]

Description was changed from

==========
Use the web_socket_channel package.

R=kevmoo@google.com
==========

to

==========
Use the web_socket_channel package.

R=kevmoo@google.com

Committed:
https://github.com/dart-lang/shelf_web_socket/commit/2027ad0d91ee02deac98354c...
==========

[nweiz, 2016-03-03 20:08:35]

Committed patchset #2 (id:20001) manually as
2027ad0d91ee02deac98354c26a299fc75668a5a (presubmit successful).