Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(235)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 17581003: Report NO_DEFAULT_SUPER_CONSTRUCTOR_EXPLICIT as CTEC. (Closed)

Created:
7 years, 6 months ago by scheglov
Modified:
7 years, 6 months ago
Reviewers:
jwren, Brian Wilkerson
CC:
reviews_dartlang.org, lukeechurch_gmail.com
Visibility:
Public.

Description

Report NO_DEFAULT_SUPER_CONSTRUCTOR_EXPLICIT as CTEC. R=brianwilkerson@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=24342

Patch Set 1 #

Total comments: 4

Patch Set 2 : tweaks #

Unified diffs Side-by-side diffs Delta from patch set Stats (+98 lines, -95 lines) Patch
M editor/tools/plugins/com.google.dart.engine.services/src/com/google/dart/engine/services/internal/correction/QuickFixProcessorImpl.java View 3 chunks +9 lines, -9 lines 0 comments Download
M editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/element/ClassElement.java View 1 chunk +0 lines, -7 lines 0 comments Download
M editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/error/CompileTimeErrorCode.java View 1 1 chunk +19 lines, -0 lines 0 comments Download
M editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/error/StaticWarningCode.java View 1 chunk +0 lines, -13 lines 0 comments Download
M editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/element/ClassElementImpl.java View 1 chunk +0 lines, -10 lines 0 comments Download
M editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/element/handle/ClassElementHandle.java View 1 chunk +0 lines, -5 lines 0 comments Download
M editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/verifier/ErrorVerifier.java View 1 3 chunks +19 lines, -9 lines 0 comments Download
M editor/tools/plugins/com.google.dart.engine_test/src/com/google/dart/engine/resolver/CompileTimeErrorCodeTest.java View 1 7 chunks +51 lines, -5 lines 0 comments Download
M editor/tools/plugins/com.google.dart.engine_test/src/com/google/dart/engine/resolver/StaticWarningCodeTest.java View 1 chunk +0 lines, -34 lines 0 comments Download
M tests/co19/co19-analyzer.status View 1 1 chunk +0 lines, -2 lines 0 comments Download
M tests/language/language_analyzer.status View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
scheglov
7 years, 6 months ago (2013-06-24 02:12:36 UTC) #1
Brian Wilkerson
LGTM https://codereview.chromium.org/17581003/diff/1/editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/error/CompileTimeErrorCode.java File editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/error/CompileTimeErrorCode.java (right): https://codereview.chromium.org/17581003/diff/1/editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/error/CompileTimeErrorCode.java#newcode774 editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/error/CompileTimeErrorCode.java:774: * enclosing class is class <i>Object</i>. nit: I ...
7 years, 6 months ago (2013-06-24 14:55:48 UTC) #2
scheglov
https://codereview.chromium.org/17581003/diff/1/editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/error/CompileTimeErrorCode.java File editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/error/CompileTimeErrorCode.java (right): https://codereview.chromium.org/17581003/diff/1/editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/error/CompileTimeErrorCode.java#newcode774 editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/error/CompileTimeErrorCode.java:774: * enclosing class is class <i>Object</i>. On 2013/06/24 14:55:48, ...
7 years, 6 months ago (2013-06-24 16:16:02 UTC) #3
scheglov
Committed patchset #2 manually as r24342 (presubmit successful).
7 years, 6 months ago (2013-06-24 16:16:36 UTC) #4
jwren
7 years, 6 months ago (2013-06-24 16:49:22 UTC) #5
Message was sent while issue was closed. 
On 2013/06/24 16:16:36, scheglov wrote:
> Committed patchset #2 manually as r24342 (presubmit successful).

LGTM

Powered by Google App Engine
This is Rietveld 408576698