Add new VirtualHost class to http_server package, for handling multiple hosts on multiple sources (…

Add new VirtualHost class to http_server package, for handling multiple hosts on multiple sources (HttpServer's).

It uses a by-name aproach, and thus depends on the host field to be
present.

BUG=
R=sgjesse@google.com

Committed: https://code.google.com/p/dart/source/detail?r=24318

[ricow1, 2013-06-24 07:41:30]

DBN (drive by nit :-) )

https://codereview.chromium.org/17581002/diff/1/pkg/http_server/lib/src/virtu...
File pkg/http_server/lib/src/virtual_host.dart (right):

https://codereview.chromium.org/17581002/diff/1/pkg/http_server/lib/src/virtu...
pkg/http_server/lib/src/virtual_host.dart:10: * multiple sources, by using
name-based approach.
using name-based -> using a named-based

https://codereview.chromium.org/17581002/diff/1/pkg/http_server/lib/src/virtu...
pkg/http_server/lib/src/virtual_host.dart:48: * If both `my.domain.name` and
`*.domain.name` is specified, the most qualified
long line

https://codereview.chromium.org/17581002/diff/1/pkg/http_server/test/virtual_...
File pkg/http_server/test/virtual_host_test.dart (right):

https://codereview.chromium.org/17581002/diff/1/pkg/http_server/test/virtual_...
pkg/http_server/test/virtual_host_test.dart:98: getStatusCode(servers[1].port,
'/', host: 'myhost2.com', secure: true)])
long line

[Søren Gjesse, 2013-06-24 07:58:37]

lgtm

https://codereview.chromium.org/17581002/diff/1/pkg/http_server/lib/src/virtu...
File pkg/http_server/lib/src/virtual_host.dart (right):

https://codereview.chromium.org/17581002/diff/1/pkg/http_server/lib/src/virtu...
pkg/http_server/lib/src/virtual_host.dart:44: * domain (`my.domain.name`) or a
wildcard-based domain name (`*.domain.name`).
Long line.

https://codereview.chromium.org/17581002/diff/1/pkg/http_server/lib/src/virtu...
pkg/http_server/lib/src/virtual_host.dart:48: * If both `my.domain.name` and
`*.domain.name` is specified, the most qualified
Long line.

https://codereview.chromium.org/17581002/diff/1/pkg/http_server/lib/src/virtu...
pkg/http_server/lib/src/virtual_host.dart:112: throw new ArgumentError('Invalid
wildcard in host');
Possibly improve this message, as wildcards are actually allowed, but only in
the beginning.

https://codereview.chromium.org/17581002/diff/1/pkg/http_server/lib/src/virtu...
pkg/http_server/lib/src/virtual_host.dart:145: request.response.statusCode =
403;
Use HttpStatus.XXX

https://codereview.chromium.org/17581002/diff/1/pkg/http_server/test/virtual_...
File pkg/http_server/test/virtual_host_test.dart (right):

https://codereview.chromium.org/17581002/diff/1/pkg/http_server/test/virtual_...
pkg/http_server/test/virtual_host_test.dart:18: var uri = (secure ? "https" :
"http") + '://localhost:$port$path';
Mow about using the new Uri.http / Uri.https constructors?

[Anders Johnsen, 2013-06-24 10:07:06]

https://codereview.chromium.org/17581002/diff/1/pkg/http_server/lib/src/virtu...
File pkg/http_server/lib/src/virtual_host.dart (right):

https://codereview.chromium.org/17581002/diff/1/pkg/http_server/lib/src/virtu...
pkg/http_server/lib/src/virtual_host.dart:10: * multiple sources, by using
name-based approach.
On 2013/06/24 07:41:30, ricow1 wrote:
> using name-based -> using a named-based

Done.

https://codereview.chromium.org/17581002/diff/1/pkg/http_server/lib/src/virtu...
pkg/http_server/lib/src/virtual_host.dart:44: * domain (`my.domain.name`) or a
wildcard-based domain name (`*.domain.name`).
On 2013/06/24 07:58:37, Søren Gjesse wrote:
> Long line.

Done.

https://codereview.chromium.org/17581002/diff/1/pkg/http_server/lib/src/virtu...
pkg/http_server/lib/src/virtual_host.dart:48: * If both `my.domain.name` and
`*.domain.name` is specified, the most qualified
On 2013/06/24 07:41:30, ricow1 wrote:
> long line

Done.

https://codereview.chromium.org/17581002/diff/1/pkg/http_server/lib/src/virtu...
pkg/http_server/lib/src/virtual_host.dart:48: * If both `my.domain.name` and
`*.domain.name` is specified, the most qualified
On 2013/06/24 07:58:37, Søren Gjesse wrote:
> Long line.

Done.

https://codereview.chromium.org/17581002/diff/1/pkg/http_server/lib/src/virtu...
pkg/http_server/lib/src/virtual_host.dart:112: throw new ArgumentError('Invalid
wildcard in host');
On 2013/06/24 07:58:37, Søren Gjesse wrote:
> Possibly improve this message, as wildcards are actually allowed, but only in
> the beginning.

Done.

https://codereview.chromium.org/17581002/diff/1/pkg/http_server/lib/src/virtu...
pkg/http_server/lib/src/virtual_host.dart:145: request.response.statusCode =
403;
On 2013/06/24 07:58:37, Søren Gjesse wrote:
> Use HttpStatus.XXX

Done.

https://codereview.chromium.org/17581002/diff/1/pkg/http_server/test/virtual_...
File pkg/http_server/test/virtual_host_test.dart (right):

https://codereview.chromium.org/17581002/diff/1/pkg/http_server/test/virtual_...
pkg/http_server/test/virtual_host_test.dart:18: var uri = (secure ? "https" :
"http") + '://localhost:$port$path';
On 2013/06/24 07:58:37, Søren Gjesse wrote:
> Mow about using the new Uri.http / Uri.https constructors?

Done.

https://codereview.chromium.org/17581002/diff/1/pkg/http_server/test/virtual_...
pkg/http_server/test/virtual_host_test.dart:98: getStatusCode(servers[1].port,
'/', host: 'myhost2.com', secure: true)])
On 2013/06/24 07:41:30, ricow1 wrote:
> long line

Done.

[Anders Johnsen, 2013-06-24 10:07:31]

Committed patchset #2 manually as r24318 (presubmit successful).