pkg/serialization: add format param to Serialization.read method

pkg/serialization: add format param to Serialization.read method

Made read/write params named instead of positional

R=alanknight@google.com

Committed: https://code.google.com/p/dart/source/detail?r=24487

[kevmoo-old, 2013-06-23 17:39:44]

PTAL

[Alan Knight, 2013-06-26 19:26:29]

Now, if I can just figure out what I'm supposed to do for a breaking change...

https://codereview.chromium.org/17578002/diff/5001/pkg/serialization/lib/seri...
File pkg/serialization/lib/serialization.dart (right):

https://codereview.chromium.org/17578002/diff/5001/pkg/serialization/lib/seri...
pkg/serialization/lib/serialization.dart:37: * and we get back a Map which is a
JSONable representation of the state of
The point of that syntax was to provide a link in the documentation that takes
you to the json package. Sadly that doesn't work, because DartDoc, but Andrei
tells me that it will work before all that long. So I'd rather leave the links
in place.

Reviews do tend to go faster when they're smaller/ more focused, so I don't have
to wait for e.g. the DartDoc guy to be in to check up on things that aren't
really part of main objective, or ponderthe merits of a final List that's
mutated versus replacing a List.

https://codereview.chromium.org/17578002/diff/5001/pkg/serialization/lib/seri...
pkg/serialization/lib/serialization.dart:436: }
I can see the one directly below, but a guard clause that fits on one line I'd
rather have as a one-liner.

https://codereview.chromium.org/17578002/diff/5001/pkg/serialization/lib/src/...
File pkg/serialization/lib/src/basic_rule.dart (right):

https://codereview.chromium.org/17578002/diff/5001/pkg/serialization/lib/src/...
pkg/serialization/lib/src/basic_rule.dart:480: if (fields == null) {
As above for a guard clause.

https://codereview.chromium.org/17578002/diff/5001/pkg/serialization/test/ser...
File pkg/serialization/test/serialization_test.dart (right):

https://codereview.chromium.org/17578002/diff/5001/pkg/serialization/test/ser...
pkg/serialization/test/serialization_test.dart:438: var result = s.read(output,
format: w.format);
I would say to leave a couple of these cases using newReader and newWriter so
that those APIs still get exercised.

[kevmoo-old, 2013-06-26 20:27:09]

Just focusing on the breaking change.

I'm happy to send the breaking change email
(https://code.google.com/p/dart/wiki/HowToWriteABreakingChangeEmail)

...assuming this LGTY

[Alan Knight, 2013-06-26 20:32:53]

Awesome, thanks. LGTM.

[kevmoo-old, 2013-06-26 20:34:56]

Committed patchset #4 manually as r24487 (presubmit successful).