Issue 17575018: Combine TYPE_ARGUMENT_VIOLATES_BOUNDS and TYPE_ARGUMENT_NOT_MATCHING_BOUNDS into TYPE_ARGUMENT_NOT_…

Issue 17575018: Combine TYPE_ARGUMENT_VIOLATES_BOUNDS and TYPE_ARGUMENT_NOT_MATCHING_BOUNDS into TYPE_ARGUMENT_NOT_… (Closed)

Created:
7 years, 6 months ago by jwren

Modified:
7 years, 6 months ago

Reviewers:
scheglov, Brian Wilkerson

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Combine TYPE_ARGUMENT_VIOLATES_BOUNDS and TYPE_ARGUMENT_NOT_MATCHING_BOUNDS into TYPE_ARGUMENT_NOT_MATCHING_BOUNDS, and cover remaining TypeName cases. R=brianwilkerson@google.com Committed: https://code.google.com/p/dart/source/detail?r=24435

Patch Set 1 #

Patch Set 2 : Javadoc nit #

Patch Set 3 : Rebase with bleeding_edge, including isSubtypeOf bug fix: https://codereview.chromium.org/17712003/ #

Patch Set 4 : Cleanup in ErrorVerifier #

Total comments: 4

Patch Set 5 : Address both comments #

Patch Set 6 : Rebase before commit #

Created: 7 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+247 lines, -54 lines)			Patch
M	editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/error/StaticTypeWarningCode.java	View	1	2 chunks	+6 lines, -9 lines	0 comments	Download
M	editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/verifier/ErrorVerifier.java	View	1 2 3 4	3 chunks	+39 lines, -33 lines	0 comments	Download
M	editor/tools/plugins/com.google.dart.engine_test/src/com/google/dart/engine/resolver/NonErrorResolverTest.java	View	1 2	1 chunk	+24 lines, -0 lines	0 comments	Download
M	editor/tools/plugins/com.google.dart.engine_test/src/com/google/dart/engine/resolver/StaticTypeWarningCodeTest.java	View	1 2 3 4	4 chunks	+174 lines, -9 lines	0 comments	Download
M	tests/co19/co19-analyzer.status	View	1 2	1 chunk	+4 lines, -0 lines	0 comments	Download
M	tests/language/language_analyzer.status	View	1 2	1 chunk	+0 lines, -3 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

Brian Wilkerson

LGTM with just a little clean-up https://codereview.chromium.org/17575018/diff/7001/editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/verifier/ErrorVerifier.java File editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/verifier/ErrorVerifier.java (right): https://codereview.chromium.org/17575018/diff/7001/editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/verifier/ErrorVerifier.java#newcode4001 editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/verifier/ErrorVerifier.java:4001: if (node.getTypeArguments() == ...

7 years, 6 months ago (2013-06-25 21:10:49 UTC) #2

jwren

https://codereview.chromium.org/17575018/diff/7001/editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/verifier/ErrorVerifier.java File editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/verifier/ErrorVerifier.java (right): https://codereview.chromium.org/17575018/diff/7001/editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/verifier/ErrorVerifier.java#newcode4001 editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/verifier/ErrorVerifier.java:4001: if (node.getTypeArguments() == null || node.getParent() instanceof TypeArgumentList Done. ...

7 years, 6 months ago (2013-06-25 22:04:51 UTC) #3

jwren

Committed patchset #6 manually as r24435 (presubmit successful).

7 years, 6 months ago (2013-06-25 22:07:36 UTC) #4

Message was sent while issue was closed.

LGTM

Expand Messages | Collapse Messages