Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(267)

Issue 17574008: Fixing DateTime values in dart2js serialized script values. (Closed)

Created:
7 years, 6 months ago by blois
Modified:
7 years, 5 months ago
Reviewers:
sra1
CC:
reviews_dartlang.org, vsm
Visibility:
Public.

Description

Fixing DateTime values in serialized script values. This allows Dart's DateTime objects to be passed as serialized script values. Especially useful for DB values. BUG=11449 R=sra@google.com Committed: https://code.google.com/p/dart/source/detail?r=24608

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+34 lines, -45 lines) Patch
M sdk/lib/html/dart2js/html_dart2js.dart View 6 chunks +5 lines, -14 lines 0 comments Download
M sdk/lib/html/html_common/conversions.dart View 3 chunks +11 lines, -4 lines 0 comments Download
M tests/html/indexeddb_1_test.dart View 2 chunks +16 lines, -16 lines 0 comments Download
M tools/dom/scripts/generator.py View 1 chunk +2 lines, -2 lines 0 comments Download
M tools/dom/src/dart2js_Conversions.dart View 1 chunk +0 lines, -9 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
blois
7 years, 6 months ago (2013-06-24 23:37:41 UTC) #1
sra1
lgtm
7 years, 6 months ago (2013-06-25 19:58:06 UTC) #2
blois
7 years, 5 months ago (2013-06-28 20:55:29 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r24608 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698