Issue 17573011: Add auto-detection of MIME-type in VirtualDirectory.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 17573011: Add auto-detection of MIME-type in VirtualDirectory. (Closed)

Created:
7 years, 6 months ago by Anders Johnsen

Modified:
7 years, 6 months ago

Reviewers:
Søren Gjesse

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

Add auto-detection of MIME-type in VirtualDirectory. Default charset for text/* is still missing. BUG= R=sgjesse@google.com Committed: https://code.google.com/p/dart/source/detail?r=24328

Created: 7 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+107 lines, -3 lines)			Patch
M	pkg/http_server/lib/http_server.dart	View		1 chunk	+2 lines, -0 lines	0 comments	Download
M	pkg/http_server/lib/src/virtual_directory.dart	View		2 chunks	+62 lines, -2 lines	0 comments	Download
M	pkg/http_server/pubspec.yaml	View	1	1 chunk	+2 lines, -0 lines	0 comments	Download
M	pkg/http_server/test/virtual_directory_test.dart	View		2 chunks	+41 lines, -1 line	0 comments	Download

Total messages: 3 (0 generated)

Søren Gjesse

lgtm, maybe there should be a way to turn off the magic bytes checking and ...

7 years, 6 months ago (2013-06-24 13:00:30 UTC) #2

Anders Johnsen

7 years, 6 months ago (2013-06-24 13:05:48 UTC) #3

Message was sent while issue was closed.

Committed patchset #2 manually as r24328 (presubmit successful).