Issue 17573010: Add a static method decode to StringDecoder

Issue 17573010: Add a static method decode to StringDecoder (Closed)

Created:
7 years, 6 months ago by Søren Gjesse

Modified:
7 years, 6 months ago

Reviewers:
Anders Johnsen

CC:
reviews_dartlang.org, ricow1

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Add a static method decode to StringDecoder R=ajohnsen@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=24335

Patch Set 1 #

Total comments: 6

Created: 7 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+55 lines, -2 lines)			Patch
	M	sdk/lib/io/string_transformer.dart	View		1 chunk	+25 lines, -0 lines	6 comments	Download
	M	tests/standalone/io/string_decoder_test.dart	View		3 chunks	+30 lines, -2 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Anders Johnsen

LGTM https://codereview.chromium.org/17573010/diff/1/sdk/lib/io/string_transformer.dart File sdk/lib/io/string_transformer.dart (right): https://codereview.chromium.org/17573010/diff/1/sdk/lib/io/string_transformer.dart#newcode105 sdk/lib/io/string_transformer.dart:105: int replacementChar]) { Type in replacement char? https://codereview.chromium.org/17573010/diff/1/sdk/lib/io/string_transformer.dart#newcode107 ...

7 years, 6 months ago (2013-06-24 12:57:16 UTC) #2

Søren Gjesse

https://codereview.chromium.org/17573010/diff/1/sdk/lib/io/string_transformer.dart File sdk/lib/io/string_transformer.dart (right): https://codereview.chromium.org/17573010/diff/1/sdk/lib/io/string_transformer.dart#newcode105 sdk/lib/io/string_transformer.dart:105: int replacementChar]) { On 2013/06/24 12:57:16, Anders Johnsen wrote: ...

7 years, 6 months ago (2013-06-24 13:18:16 UTC) #3

Søren Gjesse

7 years, 6 months ago (2013-06-24 13:56:27 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 manually as r24335 (presubmit successful).

Expand Messages | Collapse Messages