Reland: Optimizing noSuchMethod invocation with no arguments.

Reland: Optimizing noSuchMethod invocation with no arguments.

This is the same CL as https://codereview.chromium.org/17315008/ with
one bug fixed:

If a method is invoked with a mismatching number of arguments, we don't
add a no-such-method-dispatcher function since the dispatcher currently
can only invoke noSuchMethod and would not work if the method
is invoked with correct arguments at a later point.

I extended the test to cover that case.

TEST=tests/language/no_such_method_dispatcher_test.dart
R=srdjan@google.com

Committed: https://code.google.com/p/dart/source/detail?r=24351

[Florian Schneider, 2013-06-24 12:25:44]

https://codereview.chromium.org/17571010/diff/1/runtime/vm/code_generator.cc
File runtime/vm/code_generator.cc (right):

https://codereview.chromium.org/17571010/diff/1/runtime/vm/code_generator.cc#...
runtime/vm/code_generator.cc:1260: if (target_function.IsNull() &&
Added the check if a function with that name already exists.

[srdjan, 2013-06-24 16:23:27]

lgtm

https://codereview.chromium.org/17571010/diff/1/tests/language/no_such_method...
File tests/language/no_such_method_dispatcher_test.dart (right):

https://codereview.chromium.org/17571010/diff/1/tests/language/no_such_method...
tests/language/no_such_method_dispatcher_test.dart:20: for (var i = 0; i < 5000;
++i) Expect.equals(123, a.foo());
That may not trigger optimization. Safer and faster would be to reduce it to 100
and set VM option to trigger optimization at 100.

https://codereview.chromium.org/17571010/diff/1/tests/language/no_such_method...
tests/language/no_such_method_dispatcher_test.dart:25: for (var i = 0; i < 5000;
++i) {
ditto.

[Florian Schneider, 2013-06-24 17:19:06]

Committed patchset #3 manually as r24351 (presubmit successful).

[Florian Schneider, 2013-06-24 17:19:15]

https://codereview.chromium.org/17571010/diff/1/tests/language/no_such_method...
File tests/language/no_such_method_dispatcher_test.dart (right):

https://codereview.chromium.org/17571010/diff/1/tests/language/no_such_method...
tests/language/no_such_method_dispatcher_test.dart:20: for (var i = 0; i < 5000;
++i) Expect.equals(123, a.foo());
On 2013/06/24 16:23:27, srdjan wrote:
> That may not trigger optimization. Safer and faster would be to reduce it to
100
> and set VM option to trigger optimization at 100.

Done.

https://codereview.chromium.org/17571010/diff/1/tests/language/no_such_method...
tests/language/no_such_method_dispatcher_test.dart:25: for (var i = 0; i < 5000;
++i) {
On 2013/06/24 16:23:27, srdjan wrote:
> ditto.

Done.