Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(604)

Issue 17570018: Do not compile tests for different browsers separately (Closed)

Created:
7 years, 6 months ago by kustermann
Modified:
7 years, 6 months ago
Reviewers:
ricow1
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Do not compile tests for different browsers separately Currently we recompile tests with dart2js for all browsers. There is no need to do these compilations for all browsers, since the output should be exactly the same. R=ricow@google.com Committed: https://code.google.com/p/dart/source/detail?r=24402

Patch Set 1 #

Total comments: 8

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+68 lines, -16 lines) Patch
M tests/standalone/io/skipping_dart2js_compilations_test.dart View 1 chunk +5 lines, -0 lines 0 comments Download
M tools/testing/dart/test_runner.dart View 1 5 chunks +36 lines, -3 lines 0 comments Download
M tools/testing/dart/test_suite.dart View 1 9 chunks +27 lines, -13 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
kustermann
7 years, 6 months ago (2013-06-25 12:19:07 UTC) #1
ricow1
LGTM, I think we should a a comment somewhere to actually explain _why_ we do ...
7 years, 6 months ago (2013-06-25 13:10:48 UTC) #2
kustermann
https://codereview.chromium.org/17570018/diff/1/tools/testing/dart/test_runner.dart File tools/testing/dart/test_runner.dart (right): https://codereview.chromium.org/17570018/diff/1/tools/testing/dart/test_runner.dart#newcode201 tools/testing/dart/test_runner.dart:201: toFile.writeAsBytesSync(fromFile.readAsBytesSync()); On 2013/06/25 13:10:48, ricow1 wrote: > add small ...
7 years, 6 months ago (2013-06-25 13:20:11 UTC) #3
kustermann
7 years, 6 months ago (2013-06-25 13:25:19 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 manually as r24402 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698