Issue 17570006: Don't test links on Windows, as we can't create relative links, in http_server.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 17570006: Don't test links on Windows, as we can't create relative links, in http_server. (Closed)

Created:
7 years, 6 months ago by Anders Johnsen

Modified:
7 years, 6 months ago

Reviewers:
Søren Thygesen Gjesse, Søren Gjesse

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Don't test links on Windows, as we can't create relative links, in http_server. BUG= Committed: https://code.google.com/p/dart/source/detail?r=24312

Patch Set 1 #

Total comments: 1

Created: 7 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+82 lines, -76 lines)			Patch
	M	pkg/http_server/test/virtual_directory_test.dart	View		3 chunks	+82 lines, -76 lines	1 comment	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Anders Johnsen

Committed patchset #1 manually as r24312 (presubmit successful).

7 years, 6 months ago (2013-06-24 09:07:36 UTC) #2

Søren Gjesse

7 years, 6 months ago (2013-06-24 09:49:57 UTC) #4

Message was sent while issue was closed.

lgtm

https://codereview.chromium.org/17570006/diff/1/pkg/http_server/test/virtual_...
File pkg/http_server/test/virtual_directory_test.dart (right):

https://codereview.chromium.org/17570006/diff/1/pkg/http_server/test/virtual_...
pkg/http_server/test/virtual_directory_test.dart:138: group('links', () {
group is missing a predicate argument.

Expand Messages | Collapse Messages