Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(192)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 17570003: Report ParserErrorCode.STATIC_FUNCTION_DECLARATION (Closed)

Created:
7 years, 6 months ago by scheglov
Modified:
7 years, 6 months ago
Reviewers:
jwren, Brian Wilkerson
CC:
reviews_dartlang.org, lukeechurch_gmail.com
Visibility:
Public.

Description

Report ParserErrorCode.STATIC_FUNCTION_DECLARATION R=brianwilkerson@google.com, jwren@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=24352

Patch Set 1 #

Total comments: 2

Patch Set 2 : Check all modifiers #

Unified diffs Side-by-side diffs Delta from patch set Stats (+37 lines, -1 line) Patch
M editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/parser/Parser.java View 1 2 chunks +16 lines, -0 lines 0 comments Download
M editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/parser/ParserErrorCode.java View 1 1 chunk +1 line, -0 lines 0 comments Download
M editor/tools/plugins/com.google.dart.engine_test/src/com/google/dart/engine/parser/ErrorParserTest.java View 1 2 chunks +20 lines, -0 lines 0 comments Download
M tests/co19/co19-analyzer.status View 1 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 6 (0 generated)
scheglov
7 years, 6 months ago (2013-06-23 20:21:48 UTC) #1
Brian Wilkerson
LGTM after comment is addressed https://codereview.chromium.org/17570003/diff/1/editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/parser/Parser.java File editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/parser/Parser.java (right): https://codereview.chromium.org/17570003/diff/1/editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/parser/Parser.java#newcode6089 editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/parser/Parser.java:6089: if (modifiers.getStaticKeyword() != null) ...
7 years, 6 months ago (2013-06-24 13:45:12 UTC) #2
jwren
On 2013/06/24 13:45:12, Brian Wilkerson wrote: > LGTM after comment is addressed > > https://codereview.chromium.org/17570003/diff/1/editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/parser/Parser.java ...
7 years, 6 months ago (2013-06-24 16:46:05 UTC) #3
scheglov
PTAL https://codereview.chromium.org/17570003/diff/1/editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/parser/Parser.java File editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/parser/Parser.java (right): https://codereview.chromium.org/17570003/diff/1/editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/parser/Parser.java#newcode6089 editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/parser/Parser.java:6089: if (modifiers.getStaticKeyword() != null) { On 2013/06/24 13:45:12, ...
7 years, 6 months ago (2013-06-24 16:51:51 UTC) #4
Brian Wilkerson
LGTM
7 years, 6 months ago (2013-06-24 16:58:52 UTC) #5
scheglov
7 years, 6 months ago (2013-06-24 17:22:26 UTC) #6
Message was sent while issue was closed. 
Committed patchset #2 manually as r24352 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698