Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(308)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1756613002: Add an IO implementation of WebSocketChannel. (Closed)

Created:
4 years, 9 months ago by nweiz
Modified:
4 years, 9 months ago
Reviewers:
kevmoo
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/web_socket_channel.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 6
Unified diffs Side-by-side diffs Delta from patch set Stats (+453 lines, -3 lines) Patch
A README.md View 1 chunk +79 lines, -0 lines 0 comments Download
A lib/io.dart View 1 chunk +113 lines, -0 lines 2 comments Download
M lib/src/channel.dart View 1 chunk +1 line, -1 line 0 comments Download
M lib/src/exception.dart View 1 chunk +5 lines, -1 line 0 comments Download
A lib/src/sink_completer.dart View 1 chunk +153 lines, -0 lines 0 comments Download
M lib/web_socket_channel.dart View 1 chunk +1 line, -1 line 0 comments Download
A test/io_test.dart View 1 chunk +101 lines, -0 lines 4 comments Download

Messages

Total messages: 5 (1 generated)
nweiz
4 years, 9 months ago (2016-03-01 22:39:50 UTC) #1
kevmoo
lgtm https://codereview.chromium.org/1756613002/diff/1/lib/io.dart File lib/io.dart (right): https://codereview.chromium.org/1756613002/diff/1/lib/io.dart#newcode41 lib/io.dart:41: String get protocol => _webSocket?.protocol; document that these ...
4 years, 9 months ago (2016-03-01 23:24:47 UTC) #2
nweiz
Committed patchset #1 (id:1) manually as cda6f1ecd05eedb88c49b3988c70f8b0dbc23c95 (presubmit successful).
4 years, 9 months ago (2016-03-02 00:08:56 UTC) #4
nweiz
4 years, 9 months ago (2016-03-02 00:10:20 UTC) #5
Message was sent while issue was closed. 
https://codereview.chromium.org/1756613002/diff/1/lib/io.dart
File lib/io.dart (right):

https://codereview.chromium.org/1756613002/diff/1/lib/io.dart#newcode41
lib/io.dart:41: String get protocol => _webSocket?.protocol;
On 2016/03/01 23:24:46, kevmoo wrote:
> document that these can be null if not connected?

That's documented in the superclass.

https://codereview.chromium.org/1756613002/diff/1/test/io_test.dart
File test/io_test.dart (right):

https://codereview.chromium.org/1756613002/diff/1/test/io_test.dart#newcode9
test/io_test.dart:9: import 'package:stream_channel/stream_channel.dart';
On 2016/03/01 23:24:47, kevmoo wrote:
> unused import?

Done.

https://codereview.chromium.org/1756613002/diff/1/test/io_test.dart#newcode99
test/io_test.dart:99: throwsA(new isInstanceOf<WebSocketChannelException>()));
On 2016/03/01 23:24:46, kevmoo wrote:
> missing import of lib w/ WebSocketChannelException

Done.

Powered by Google App Engine
This is Rietveld 408576698