Add a validation for the name parameter not matching the function name

Add a validation for the name parameter not matching the function name

BUG=
R=efortuna@google.com

Committed: https://code.google.com/p/dart/source/detail?r=32976

[Emily Fortuna, 2014-02-24 18:38:23]

lgtm, one suggestion

https://codereview.chromium.org/175543003/diff/1/pkg/intl/lib/src/intl_messag...
File pkg/intl/lib/src/intl_message.dart (right):

https://codereview.chromium.org/175543003/diff/1/pkg/intl/lib/src/intl_messag...
pkg/intl/lib/src/intl_message.dart:360: set name(String newName) { _name =
newName; }
I'd be inclined to leave the "void" in this line, but personal preference.

[Alan Knight, 2014-02-24 18:46:44]

https://codereview.chromium.org/175543003/diff/1/pkg/intl/lib/src/intl_messag...
File pkg/intl/lib/src/intl_message.dart (right):

https://codereview.chromium.org/175543003/diff/1/pkg/intl/lib/src/intl_messag...
pkg/intl/lib/src/intl_message.dart:360: set name(String newName) { _name =
newName; }
On 2014/02/24 18:38:23, Emily Fortuna wrote:
> I'd be inclined to leave the "void" in this line, but personal preference.

I got dinged before in a review for having that, since a setter is always void.
Which made sense to me.

[Alan Knight, 2014-02-24 18:49:12]

Committed patchset #1 manually as r32976 (presubmit successful).

[Emily Fortuna, 2014-02-24 18:57:45]

> I got dinged before in a review for having that, since a setter is always
void.
> Which made sense to me.
I agree that a setter is always void, but I'm inclined to provide more
information if available rather than omit. But it's personal preference.