Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(528)

Issue 175533003: Handle stepping requests after isolate interrupt event (Closed)

Created:
6 years, 10 months ago by hausner
Modified:
6 years, 10 months ago
Reviewers:
regis, Jacob
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Visibility:
Public.

Description

Handle stepping requests after isolate interrupt event Adding test case provided by jacobr. Fix issue 17008 R=jacobr@google.com, regis@google.com Committed: https://code.google.com/p/dart/source/detail?r=32938

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+61 lines, -50 lines) Patch
M runtime/vm/code_generator.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M runtime/vm/debugger.h View 2 chunks +4 lines, -1 line 0 comments Download
M runtime/vm/debugger.cc View 6 chunks +42 lines, -44 lines 0 comments Download
M runtime/vm/debugger_api_impl_test.cc View 5 chunks +13 lines, -3 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
hausner
6 years, 10 months ago (2014-02-21 19:02:13 UTC) #1
Jacob
lgtm for test portion of this CL I've patched this CL into Dartium and it ...
6 years, 10 months ago (2014-02-21 19:37:11 UTC) #2
hausner
Regis, do you mind taking a quick look at the changes in the VM? Thank ...
6 years, 10 months ago (2014-02-21 19:40:48 UTC) #3
regis
LGTM
6 years, 10 months ago (2014-02-21 21:44:06 UTC) #4
hausner
6 years, 10 months ago (2014-02-21 22:40:17 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 manually as r32938 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698