Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(61)

Issue 17553003: Add an exhaustive test of for loops. (Closed)

Created:
7 years, 6 months ago by Kevin Millikin (Google)
Modified:
7 years, 6 months ago
Reviewers:
srdjan, Ivan Posva
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Add an exhaustive test of for loops. Test 52 different versions of for loops created by including or leaving off various bits of the loop structure. BUG= R=iposva@google.com, srdjan@google.com Committed: https://code.google.com/p/dart/source/detail?r=24384

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+808 lines, -0 lines) Patch
A tests/language/exhaustive_for_test.dart View 1 chunk +808 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Kevin Millikin (Google)
All tests pass. Tests number 26, 27, 56, 57, 58, and 59 would have failed ...
7 years, 6 months ago (2013-06-21 12:34:42 UTC) #1
srdjan
LGTM and thanks!
7 years, 6 months ago (2013-06-21 16:24:15 UTC) #2
srdjan
You could make sure that they are run in optimized code as well, by adding ...
7 years, 6 months ago (2013-06-21 16:26:03 UTC) #3
Ivan Posva
LGTM Thanks, -Ivan
7 years, 6 months ago (2013-06-21 16:51:23 UTC) #4
Kevin Millikin (Google)
7 years, 6 months ago (2013-06-25 07:50:52 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 manually as r24384 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698