Issue 17550014: Fixing up previous CL to fix Dartium issues.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 17550014: Fixing up previous CL to fix Dartium issues. (Closed)

Created:
7 years, 6 months ago by blois

Modified:
7 years, 6 months ago

Reviewers:
vsm

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Fixing up previous CL to fix Dartium issues. patch from issue 17453003 BUG= R=vsm@google.com Committed: https://code.google.com/p/dart/source/detail?r=24354

Patch Set 1 #

Total comments: 1

Created: 7 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+20 lines, -3 lines)			Patch
M	sdk/lib/web_gl/dart2js/web_gl_dart2js.dart	View	1 chunk	+6 lines, -0 lines	0 comments	Download
M	sdk/lib/web_gl/dartium/web_gl_dartium.dart	View	1 chunk	+5 lines, -0 lines	0 comments	Download
M	tools/dom/dom.json	View	2 chunks	+3 lines, -2 lines	0 comments	Download
M	tools/dom/scripts/dartgenerator.py	View	1 chunk	+4 lines, -1 line	0 comments	Download
M	tools/dom/scripts/generator.py	View	1 chunk	+2 lines, -0 lines	1 comment	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

blois

https://codereview.chromium.org/17550014/diff/1/tools/dom/scripts/generator.py File tools/dom/scripts/generator.py (right): https://codereview.chromium.org/17550014/diff/1/tools/dom/scripts/generator.py#newcode1032 tools/dom/scripts/generator.py:1032: native_type='unsigned'), Forgot to make the base CL first, the ...

7 years, 6 months ago (2013-06-21 23:42:51 UTC) #1

blois

7 years, 6 months ago (2013-06-24 17:49:30 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as r24354 (presubmit successful).

Expand Messages | Collapse Messages