Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(31)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1754503002: Add a test for tags to configuration_test. (Closed)

Created:
4 years, 9 months ago by nweiz
Modified:
4 years, 9 months ago
Reviewers:
kevmoo
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/test@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Add a test for tags to configuration_test. I forgot to do this when first adding the feature. R=kevmoo@google.com Committed: https://github.com/dart-lang/test/commit/b2843febeeb2e0d553a3369bf4b267a342b9bce9

Patch Set 1 #

Total comments: 4

Patch Set 2 : Code review changes #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -1 line) Patch
M test/runner/configuration/configuration_test.dart View 1 2 chunks +23 lines, -1 line 0 comments Download

Messages

Total messages: 6 (1 generated)
nweiz
4 years, 9 months ago (2016-03-01 02:23:57 UTC) #1
kevmoo
lgtm https://codereview.chromium.org/1754503002/diff/1/lib/src/runner/configuration.dart File lib/src/runner/configuration.dart (right): https://codereview.chromium.org/1754503002/diff/1/lib/src/runner/configuration.dart#newcode13 lib/src/runner/configuration.dart:13: import '../backend/operating_system.dart'; Unneeded import... https://codereview.chromium.org/1754503002/diff/1/test/runner/configuration/configuration_test.dart File test/runner/configuration/configuration_test.dart (right): ...
4 years, 9 months ago (2016-03-01 06:01:12 UTC) #2
nweiz
Code review changes
4 years, 9 months ago (2016-03-01 19:24:41 UTC) #3
nweiz
https://codereview.chromium.org/1754503002/diff/1/lib/src/runner/configuration.dart File lib/src/runner/configuration.dart (right): https://codereview.chromium.org/1754503002/diff/1/lib/src/runner/configuration.dart#newcode13 lib/src/runner/configuration.dart:13: import '../backend/operating_system.dart'; On 2016/03/01 06:01:12, kevmoo wrote: > Unneeded ...
4 years, 9 months ago (2016-03-01 19:24:49 UTC) #4
nweiz
4 years, 9 months ago (2016-03-01 19:25:12 UTC) #6
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) manually as
b2843febeeb2e0d553a3369bf4b267a342b9bce9 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698