Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(458)

Issue 17544005: First push of a new 'http_server' dart package. (Closed)

Created:
7 years, 6 months ago by Anders Johnsen
Modified:
7 years, 6 months ago
Reviewers:
Søren Gjesse
CC:
reviews_dartlang.org
Visibility:
Public.

Description

First push of a new 'http_server' dart package. The package will contain helper-classes for writing http server, such as VirtualDirectory, VirtualHost etc. BUG= R=sgjesse@google.com Committed: https://code.google.com/p/dart/source/detail?r=24281

Patch Set 1 #

Total comments: 10

Patch Set 2 : Review changes. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+262 lines, -4 lines) Patch
A + pkg/http_server/lib/http_server.dart View 1 1 chunk +5 lines, -2 lines 0 comments Download
A pkg/http_server/lib/src/virtual_directory.dart View 1 1 chunk +122 lines, -0 lines 0 comments Download
A + pkg/http_server/pubspec.yaml View 1 chunk +2 lines, -2 lines 0 comments Download
A pkg/http_server/test/virtual_directory_test.dart View 1 1 chunk +132 lines, -0 lines 0 comments Download
M utils/apidoc/apidoc.gyp View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Anders Johnsen
7 years, 6 months ago (2013-06-21 10:54:09 UTC) #1
Søren Gjesse
LGTM, but make sure that no dartdoc is published for now. https://codereview.chromium.org/17544005/diff/1/pkg/http_server/lib/src/virtual_directory.dart File pkg/http_server/lib/src/virtual_directory.dart (right): ...
7 years, 6 months ago (2013-06-21 11:17:23 UTC) #2
Anders Johnsen
https://codereview.chromium.org/17544005/diff/1/pkg/http_server/lib/src/virtual_directory.dart File pkg/http_server/lib/src/virtual_directory.dart (right): https://codereview.chromium.org/17544005/diff/1/pkg/http_server/lib/src/virtual_directory.dart#newcode37 pkg/http_server/lib/src/virtual_directory.dart:37: On 2013/06/21 11:17:23, Søren Gjesse wrote: > Dartdoc for ...
7 years, 6 months ago (2013-06-21 11:22:28 UTC) #3
Anders Johnsen
7 years, 6 months ago (2013-06-21 11:22:42 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 manually as r24281 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698