first cut cmdline analysis server launcher

first cut cmdline analysis server launcher

BUG=
R=brianwilkerson@google.com

Committed: https://code.google.com/p/dart/source/detail?r=32903

[Brian Wilkerson, 2014-02-21 15:09:54]

LGTM

https://codereview.chromium.org/175173002/diff/1/pkg/analysis_server/bin/dart...
File pkg/analysis_server/bin/dartdeps.dart (right):

https://codereview.chromium.org/175173002/diff/1/pkg/analysis_server/bin/dart...
pkg/analysis_server/bin/dartdeps.dart:24: class _DartDependencyAnalyzer {
Style question: In analysis server I put the private classes into a private
library (as public classes) and imported them. I'm not sure which is better, but
I don't like reading underscores and my approach allowed me to remove them
without exposing them as public API. I'd be interested in your thoughts.

https://codereview.chromium.org/175173002/diff/1/pkg/analysis_server/bin/dart...
pkg/analysis_server/bin/dartdeps.dart:28: static const BINARY_NAME = 'dartdeps';
I thought I remembered that the application was going to analyze dependencies
between packages and was therefore going to be named "pkgdeps". But if you like
this better, I'm not objecting.

https://codereview.chromium.org/175173002/diff/1/pkg/analysis_server/bin/dart...
pkg/analysis_server/bin/dartdeps.dart:84: void _analyze(AnalysisManager mgr) {
Style question: Is there any value in marking an instance method as being
private when it is defined in a private class? Unless you return an instance of
this class somewhere then no-one can ever invoke this method anyway.

https://codereview.chromium.org/175173002/diff/1/pkg/analysis_server/lib/src/...
File pkg/analysis_server/lib/src/analysis_manager.dart (right):

https://codereview.chromium.org/175173002/diff/1/pkg/analysis_server/lib/src/...
pkg/analysis_server/lib/src/analysis_manager.dart:74: bool stop() =>
process.kill();
It would be nicer to ask the server to quit than to simply kill the the process
:-)

[danrubel, 2014-02-21 15:51:12]

https://codereview.chromium.org/175173002/diff/1/pkg/analysis_server/bin/dart...
File pkg/analysis_server/bin/dartdeps.dart (right):

https://codereview.chromium.org/175173002/diff/1/pkg/analysis_server/bin/dart...
pkg/analysis_server/bin/dartdeps.dart:24: class _DartDependencyAnalyzer {
On 2014/02/21 15:09:54, Brian Wilkerson wrote:
> Style question: In analysis server I put the private classes into a private
> library (as public classes) and imported them. I'm not sure which is better,
but
> I don't like reading underscores and my approach allowed me to remove them
> without exposing them as public API. I'd be interested in your thoughts.

I made it private and kept it in this library because
1) it is tightly coupled with the main method
2) it should not be reused by any other internal or external library
3) it keeps the code together

https://codereview.chromium.org/175173002/diff/1/pkg/analysis_server/bin/dart...
pkg/analysis_server/bin/dartdeps.dart:28: static const BINARY_NAME = 'dartdeps';
On 2014/02/21 15:09:54, Brian Wilkerson wrote:
> I thought I remembered that the application was going to analyze dependencies
> between packages and was therefore going to be named "pkgdeps". But if you
like
> this better, I'm not objecting.

I like "dartdeps" because this is more the just showing package dependencies,
but I'm happy to change it if there is something better.

https://codereview.chromium.org/175173002/diff/1/pkg/analysis_server/bin/dart...
pkg/analysis_server/bin/dartdeps.dart:84: void _analyze(AnalysisManager mgr) {
On 2014/02/21 15:09:54, Brian Wilkerson wrote:
> Style question: Is there any value in marking an instance method as being
> private when it is defined in a private class? Unless you return an instance
of
> this class somewhere then no-one can ever invoke this method anyway.

Good point! Removed _

[danrubel, 2014-02-21 15:54:26]

Committed patchset #3 manually as r32903 (presubmit successful).