Add support for --hide-package-warnings to pub but negate it in

Add support for --hide-package-warnings (new dart2js option) to pub but
rename it to suppressPackageWarnings to be more consistent with the
other flags. Defaults to true.

R=johnniwinther@google.com, rnystrom@google.com
BUG=

Committed: https://code.google.com/p/dart/source/detail?r=33007

[Johnni Winther, 2014-02-21 12:35:44]

lgtm

[Bob Nystrom, 2014-02-21 17:58:24]

https://codereview.chromium.org/175083002/diff/1/sdk/lib/_internal/pub/lib/sr...
File sdk/lib/_internal/pub/lib/src/barback/dart2js_transformer.dart (right):

https://codereview.chromium.org/175083002/diff/1/sdk/lib/_internal/pub/lib/sr...
sdk/lib/_internal/pub/lib/src/barback/dart2js_transformer.dart:30: 'analyzeAll',
'suppressWarnings', 'suppressHints', 'showPackageWarnings',
Let's make this "hidePackageWarnings" (or "suppress", see below) too, so that
the user-facing API is consistently named.

https://codereview.chromium.org/175083002/diff/1/sdk/lib/_internal/pub/lib/sr...
sdk/lib/_internal/pub/lib/src/barback/dart2js_transformer.dart:121:
hidePackageWarnings: !_configBool('showPackageWarnings'),
For consistency: "hidePackageWarnings" -> "suppressPackageWarnings".

[kasperl, 2014-02-24 09:16:43]

PTAL. I initially went for showPackageWarnings to keep the default set to false
(like all the other boolean options).

[Bob Nystrom, 2014-02-24 16:57:44]

On 2014/02/24 09:16:43, kasperl wrote:
> PTAL. I initially went for showPackageWarnings to keep the default set to
false
> (like all the other boolean options).

That makes sense too, but I'm OK with options having different defaults if it
gives them more consistent names.

LGTM! Thanks for doing this!

- bob

[kasperl, 2014-02-25 07:38:10]

Committed patchset #3 manually as r33007 (presubmit successful).