Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(79)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 17503002: Stop unwanted class finalization when using dart:io HttpClient from builtin.dart (Closed)

Created:
7 years, 6 months ago by Cutch
Modified:
7 years, 6 months ago
Reviewers:
siva, Ivan Posva
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Stop unwanted class finalization when using dart:io HttpClient from builtin.dart BUG=11232 R=iposva@google.com Committed: https://code.google.com/p/dart/source/detail?r=24252

Patch Set 1 #

Patch Set 2 : Less nasty #

Patch Set 3 : Block class finalization when calling into library tag handler #

Total comments: 2

Patch Set 4 : #

Patch Set 5 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -14 lines) Patch
M runtime/vm/dart_api_impl.cc View 1 2 3 4 3 chunks +8 lines, -14 lines 0 comments Download
M runtime/vm/isolate.h View 1 2 2 chunks +16 lines, -0 lines 0 comments Download
M runtime/vm/isolate.cc View 1 1 chunk +1 line, -0 lines 0 comments Download
M runtime/vm/parser.cc View 1 2 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Cutch
I tried various workarounds that we discussed yesterday and this (nasty?) change was the only ...
7 years, 6 months ago (2013-06-20 17:25:08 UTC) #1
Cutch
PTAL
7 years, 6 months ago (2013-06-20 19:56:08 UTC) #2
Ivan Posva
https://codereview.chromium.org/17503002/diff/6001/runtime/vm/dart_api_impl.cc File runtime/vm/dart_api_impl.cc (right): https://codereview.chromium.org/17503002/diff/6001/runtime/vm/dart_api_impl.cc#newcode136 runtime/vm/dart_api_impl.cc:136: if (ClassFinalizer::FinalizePendingClasses() && Why don't you check just here?
7 years, 6 months ago (2013-06-20 20:18:38 UTC) #3
Cutch
https://codereview.chromium.org/17503002/diff/6001/runtime/vm/dart_api_impl.cc File runtime/vm/dart_api_impl.cc (right): https://codereview.chromium.org/17503002/diff/6001/runtime/vm/dart_api_impl.cc#newcode136 runtime/vm/dart_api_impl.cc:136: if (ClassFinalizer::FinalizePendingClasses() && On 2013/06/20 20:18:38, Ivan Posva wrote: ...
7 years, 6 months ago (2013-06-20 20:27:02 UTC) #4
Ivan Posva
LGTM -ip P.S. Can you please file a bug so that we do not forget ...
7 years, 6 months ago (2013-06-20 20:32:46 UTC) #5
Cutch
7 years, 6 months ago (2013-06-20 20:51:20 UTC) #6
Message was sent while issue was closed. 
Committed patchset #5 manually as r24252 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698