Doing a call on a getter does not yield the return type of that getter.

Doing a call on a getter does not yield the return type of that getter.

Committed: https://code.google.com/p/dart/source/detail?r=24250

[ngeoffray, 2013-06-20 19:58:09]

Dan, hopefully this should fix your problem. Do you know how to patch in this CL
in your working environment?

[ngeoffray, 2013-06-20 20:24:36]

Committed patchset #1 manually as r24250 (presubmit successful).

[kasperl, 2013-06-21 05:58:00]

Maybe this actually already works, but at least extending the test case would be
good.

https://codereview.chromium.org/17502003/diff/1/sdk/lib/_internal/compiler/im...
File sdk/lib/_internal/compiler/implementation/types/simple_types_inferrer.dart
(right):

https://codereview.chromium.org/17502003/diff/1/sdk/lib/_internal/compiler/im...
sdk/lib/_internal/compiler/implementation/types/simple_types_inferrer.dart:808:
} else if (element.isGetter()) {
What happens if element is a field? Can we ever get an abstract field here?

https://codereview.chromium.org/17502003/diff/1/tests/compiler/dart2js/simple...
File tests/compiler/dart2js/simple_inferrer_test.dart (right):

https://codereview.chromium.org/17502003/diff/1/tests/compiler/dart2js/simple...
tests/compiler/dart2js/simple_inferrer_test.dart:367:
testReturnInvokeDynamicGetter() => new A().myFactory();
Extend test case with calling a field.

https://codereview.chromium.org/17502003/diff/1/tests/compiler/dart2js/simple...
tests/compiler/dart2js/simple_inferrer_test.dart:391: get myFactory => () => 42;
var myFactory2 = () => 87;

[ngeoffray, 2013-06-21 06:17:24]

Fields don't have a return type, so it should return dynamic. Also, we iterate
over a FunctionSet of concrete elements (getters, fields, methods), so no
abstract field.

I will extend the test.

On 2013/06/21 05:58:00, kasperl wrote:
> Maybe this actually already works, but at least extending the test case would
be
> good.
> 
>
https://codereview.chromium.org/17502003/diff/1/sdk/lib/_internal/compiler/im...
> File
sdk/lib/_internal/compiler/implementation/types/simple_types_inferrer.dart
> (right):
> 
>
https://codereview.chromium.org/17502003/diff/1/sdk/lib/_internal/compiler/im...
>
sdk/lib/_internal/compiler/implementation/types/simple_types_inferrer.dart:808:
> } else if (element.isGetter()) {
> What happens if element is a field? Can we ever get an abstract field here?
> 
>
https://codereview.chromium.org/17502003/diff/1/tests/compiler/dart2js/simple...
> File tests/compiler/dart2js/simple_inferrer_test.dart (right):
> 
>
https://codereview.chromium.org/17502003/diff/1/tests/compiler/dart2js/simple...
> tests/compiler/dart2js/simple_inferrer_test.dart:367:
> testReturnInvokeDynamicGetter() => new A().myFactory();
> Extend test case with calling a field.
> 
>
https://codereview.chromium.org/17502003/diff/1/tests/compiler/dart2js/simple...
> tests/compiler/dart2js/simple_inferrer_test.dart:391: get myFactory => () =>
42;
> var myFactory2 = () => 87;