Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(137)

Issue 17502002: Enables more tests for SIMMIPS. (Closed)

Created:
7 years, 6 months ago by zra
Modified:
7 years, 6 months ago
Reviewers:
regis
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Enables more tests for SIMMIPS. . Fixes register allocation bugs . Implements float <-> double conversion in assembler and simulator. . Fixes floating point argument passing for simarm and simmips, and floating point return for simarm, and adjusts tests to match. R=regis@google.com Committed: https://code.google.com/p/dart/source/detail?r=24365

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+178 lines, -111 lines) Patch
M runtime/tests/vm/vm.status View 1 2 2 chunks +1 line, -16 lines 0 comments Download
M runtime/vm/assembler_arm_test.cc View 1 2 9 chunks +8 lines, -17 lines 0 comments Download
M runtime/vm/assembler_mips.h View 1 2 1 chunk +5 lines, -0 lines 0 comments Download
M runtime/vm/assembler_mips_test.cc View 1 2 1 chunk +16 lines, -0 lines 0 comments Download
M runtime/vm/constants_mips.h View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M runtime/vm/intermediate_language_mips.cc View 1 2 10 chunks +56 lines, -29 lines 0 comments Download
M runtime/vm/intrinsifier_arm.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M runtime/vm/intrinsifier_mips.cc View 1 2 5 chunks +15 lines, -15 lines 0 comments Download
M runtime/vm/simulator_arm.h View 1 2 1 chunk +7 lines, -2 lines 0 comments Download
M runtime/vm/simulator_arm.cc View 1 2 2 chunks +21 lines, -6 lines 0 comments Download
M runtime/vm/simulator_mips.h View 1 2 1 chunk +2 lines, -1 line 0 comments Download
M runtime/vm/simulator_mips.cc View 1 2 3 chunks +31 lines, -7 lines 0 comments Download
M runtime/vm/stub_code_mips.cc View 1 2 3 chunks +4 lines, -4 lines 0 comments Download
M runtime/vm/unit_test.h View 1 2 1 chunk +2 lines, -11 lines 0 comments Download
M tests/corelib/corelib.status View 1 2 1 chunk +8 lines, -1 line 0 comments Download
M tests/language/language.status View 1 2 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
zra
7 years, 6 months ago (2013-06-20 18:10:58 UTC) #1
regis
LGTM Thanks!
7 years, 6 months ago (2013-06-24 17:42:31 UTC) #2
zra
7 years, 6 months ago (2013-06-24 20:16:25 UTC) #3
Message was sent while issue was closed.
Committed patchset #3 manually as r24365 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698