Issue 174953003: Fix analyzer status.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 174953003: Fix analyzer status. (Closed)

Created:
6 years, 10 months ago by sigurdm

Modified:
6 years, 10 months ago

Reviewers:
Johnni Winther

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Fix analyzer status. Committed: https://code.google.com/p/dart/source/detail?r=32885

Patch Set 1 : #

Total comments: 1

Created: 6 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -1 line)			Patch
	M	tests/language/language_analyzer.status	View		1 chunk	+3 lines, -1 line	1 comment	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

sigurdm

Committed patchset #1 manually as r32885 (presubmit successful).

6 years, 10 months ago (2014-02-21 10:13:23 UTC) #2

Johnni Winther

6 years, 10 months ago (2014-02-21 10:14:07 UTC) #3

Message was sent while issue was closed.

lgtm

https://codereview.chromium.org/174953003/diff/30001/tests/language/language_...
File tests/language/language_analyzer.status (right):

https://codereview.chromium.org/174953003/diff/30001/tests/language/language_...
tests/language/language_analyzer.status:476:
deferred_duplicate_prefix3_negative_test: StaticWarning
I think you also need to add these lines to language_analyzer2.status

Expand Messages | Collapse Messages