Make it strong mode clean.

Make it strong mode clean.

R=nweiz@google.com

Committed: https://github.com/dart-lang/args/commit/e2957dc71439a3efcf9eae4a631e854fcec63086

[Bob Nystrom, 2016-03-02 21:45:42]

rnystrom@google.com changed reviewers:
+ nweiz@google.com

[nweiz, 2016-03-02 23:58:54]

https://codereview.chromium.org/1748333005/diff/1/lib/command_runner.dart
File lib/command_runner.dart (right):

https://codereview.chromium.org/1748333005/diff/1/lib/command_runner.dart#new...
lib/command_runner.dart:43: String get usageFooter => null;
I thought we agreed to stop arguing about finals versus getters for values like
this.

https://codereview.chromium.org/1748333005/diff/1/lib/src/parser.dart
File lib/src/parser.dart (right):

https://codereview.chromium.org/1748333005/diff/1/lib/src/parser.dart#newcode40
lib/src/parser.dart:40: if (rest != null) this.rest.addAll(rest);
This addAll thing seems weird. Maybe change to "rest = rest ?? <String>[]".

[Bob Nystrom, 2016-03-03 00:19:08]

https://codereview.chromium.org/1748333005/diff/1/lib/command_runner.dart
File lib/command_runner.dart (right):

https://codereview.chromium.org/1748333005/diff/1/lib/command_runner.dart#new...
lib/command_runner.dart:43: String get usageFooter => null;
On 2016/03/02 23:58:54, nweiz wrote:
> I thought we agreed to stop arguing about finals versus getters for values
like
> this.

This is being overridden in subclasses, so making it a getter avoids the error
for overriding a field.

https://codereview.chromium.org/1748333005/diff/1/lib/src/parser.dart
File lib/src/parser.dart (right):

https://codereview.chromium.org/1748333005/diff/1/lib/src/parser.dart#newcode40
lib/src/parser.dart:40: if (rest != null) this.rest.addAll(rest);
On 2016/03/02 23:58:54, nweiz wrote:
> This addAll thing seems weird. Maybe change to "rest = rest ?? <String>[]".

It is a bit weird, but if I recall, it needs to copy the list that gets passed
to it anyway, so this accomplishes that too.

[nweiz, 2016-03-03 00:20:18]

lgtm

[Bob Nystrom, 2016-03-03 00:30:12]

Description was changed from

==========
Make it strong mode clean.
==========

to

==========
Make it strong mode clean.

R=nweiz@google.com

Committed:
https://github.com/dart-lang/args/commit/e2957dc71439a3efcf9eae4a631e854fcec6...
==========

[Bob Nystrom, 2016-03-03 00:30:14]

Committed patchset #1 (id:1) manually as
e2957dc71439a3efcf9eae4a631e854fcec63086 (presubmit successful).