Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(311)

Issue 17467008: add logging support for exceptions (Closed)

Created:
7 years, 6 months ago by Siggi Cherem (dart-lang)
Modified:
7 years, 6 months ago
Reviewers:
gram
CC:
reviews_dartlang.org
Visibility:
Public.

Description

add logging support for exceptions BUG= R=gram@google.com Committed: https://code.google.com/p/dart/source/detail?r=24246

Patch Set 1 #

Patch Set 2 : #

Total comments: 3

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+65 lines, -20 lines) Patch
M pkg/logging/lib/logging.dart View 1 2 3 chunks +22 lines, -20 lines 0 comments Download
M pkg/logging/test/logging_test.dart View 1 1 chunk +43 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Siggi Cherem (dart-lang)
7 years, 6 months ago (2013-06-20 00:25:35 UTC) #1
Siggi Cherem (dart-lang)
ptal
7 years, 6 months ago (2013-06-20 00:40:29 UTC) #2
gram
lgtm https://codereview.chromium.org/17467008/diff/3001/pkg/logging/lib/logging.dart File pkg/logging/lib/logging.dart (right): https://codereview.chromium.org/17467008/diff/3001/pkg/logging/lib/logging.dart#newcode320 pkg/logging/lib/logging.dart:320: LogRecord(this.level, this.message, this.loggerName, [time, this.exception]) this.loggerName, DateTime time, ...
7 years, 6 months ago (2013-06-20 00:49:23 UTC) #3
Siggi Cherem (dart-lang)
https://codereview.chromium.org/17467008/diff/3001/pkg/logging/lib/logging.dart File pkg/logging/lib/logging.dart (right): https://codereview.chromium.org/17467008/diff/3001/pkg/logging/lib/logging.dart#newcode320 pkg/logging/lib/logging.dart:320: LogRecord(this.level, this.message, this.loggerName, [time, this.exception]) On 2013/06/20 00:49:24, gram ...
7 years, 6 months ago (2013-06-20 00:57:10 UTC) #4
Siggi Cherem (dart-lang)
7 years, 6 months ago (2013-06-20 19:43:12 UTC) #5
Message was sent while issue was closed.
Committed patchset #3 manually as r24246 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698