Issue 174663006: Extending logic to find Dart's SDK directory for resolver tests

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 174663006: Extending logic to find Dart's SDK directory for resolver tests (Closed)

Created:
6 years, 10 months ago by blois

Modified:
6 years, 10 months ago

Reviewers:
Siggi Cherem (dart-lang)

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

Extending logic to find Dart's SDK directory for resolver tests Previous logic was failing when executing from VM tests where the dart-sdk folder is not built in the output directory. BUG= R=sigmund@google.com Committed: https://code.google.com/p/dart/source/detail?r=32922

Created: 6 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+30 lines, -13 lines)			Patch
M	pkg/code_transformers/lib/src/dart_sdk.dart	View	1 chunk	+18 lines, -11 lines	0 comments	Download
M	pkg/code_transformers/test/resolver_test.dart	View	1 chunk	+12 lines, -1 line	0 comments	Download
M	pkg/pkg.status	View	1 chunk	+0 lines, -1 line	0 comments	Download

Total messages: 3 (0 generated)

blois

6 years, 10 months ago (2014-02-21 20:09:43 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as r32922 (presubmit successful).