Issue 174663002: Tighten dart2js typed_data range check

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 174663002: Tighten dart2js typed_data range check (Closed)

Created:
6 years, 10 months ago by sra1

Modified:
6 years, 10 months ago

Reviewers:
floitsch

CC:
reviews_dartlang.org, Cutch

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Tighten dart2js typed_data range check The check needed to be changed from == to === to avoid being fooled by valueOf. The added 'cast' eliminates ~1.5k from swarm since the comparison was a generic call. Committed: https://code.google.com/p/dart/source/detail?r=32924

Patch Set 1 : #

Created: 6 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -1 line)			Patch
	M	sdk/lib/typed_data/dart2js/native_typed_data_dart2js.dart	View		1 chunk	+2 lines, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

sra1

6 years, 10 months ago (2014-02-21 20:25:09 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as r32924 (presubmit successful).

Expand Messages | Collapse Messages