Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(165)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 174633003: small fix in html5lib warning message (Closed)

Created:
6 years, 10 months ago by Siggi Cherem (dart-lang)
Modified:
6 years, 10 months ago
Reviewers:
Jennifer Messerly
CC:
reviews_dartlang.org
Visibility:
Public.

Description

small fix in html5lib warning message R=jmesserly@google.com Committed: https://code.google.com/p/dart/source/detail?r=32945

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M pkg/third_party/html5lib/lib/parser.dart View 1 chunk +1 line, -1 line 2 comments Download

Messages

Total messages: 5 (0 generated)
Siggi Cherem (dart-lang)
fix for https://code.google.com/p/dart/issues/detail?id=16981
6 years, 10 months ago (2014-02-21 03:12:27 UTC) #1
Jennifer Messerly
On 2014/02/21 03:12:27, Siggi Cherem (dart-lang) wrote: > fix for https://code.google.com/p/dart/issues/detail?id=16981 let me have a ...
6 years, 10 months ago (2014-02-21 23:17:45 UTC) #2
Jennifer Messerly
LGTM but would be nice to upstream a patch :D https://codereview.chromium.org/174633003/diff/1/pkg/third_party/html5lib/lib/parser.dart File pkg/third_party/html5lib/lib/parser.dart (right): https://codereview.chromium.org/174633003/diff/1/pkg/third_party/html5lib/lib/parser.dart#newcode1686 ...
6 years, 10 months ago (2014-02-21 23:22:17 UTC) #3
Siggi Cherem (dart-lang)
thx! https://codereview.chromium.org/174633003/diff/1/pkg/third_party/html5lib/lib/parser.dart File pkg/third_party/html5lib/lib/parser.dart (right): https://codereview.chromium.org/174633003/diff/1/pkg/third_party/html5lib/lib/parser.dart#newcode1686 pkg/third_party/html5lib/lib/parser.dart:1686: {"gotName": "body", "expectedName": node.tagName}); On 2014/02/21 23:22:18, John ...
6 years, 10 months ago (2014-02-21 23:35:29 UTC) #4
Siggi Cherem (dart-lang)
6 years, 10 months ago (2014-02-21 23:38:02 UTC) #5
Message was sent while issue was closed. 
Committed patchset #1 manually as r32945 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698