Detect EOF when reading stdio from terminal on Mac OS

Detect EOF when reading stdio from terminal on Mac OS

R=ajohnsen@google.com
BUG=http://dartbug.com/453

patch from issue 17381012

Committed: https://code.google.com/p/dart/source/detail?r=24397

[Anders Johnsen, 2013-06-20 12:10:48]

LGTM, though I wonder if we somehow could move this to native code (as it's
already platform depended).

Do you think we can add a test for this?

Also, how will this work with --short-socket-read testing?

https://codereview.chromium.org/17463003/diff/5001/runtime/bin/socket_patch.dart
File runtime/bin/socket_patch.dart (right):

https://codereview.chromium.org/17463003/diff/5001/runtime/bin/socket_patch.d...
runtime/bin/socket_patch.dart:1030: if (Platform.operatingSystem == "macos") {
Platform.isMacos :)

[Søren Gjesse, 2013-06-25 10:17:40]

PTAL

Refactored this and moved the read closed detection to RawSocket.

It is difficult to make a test for this unless we add a way to fake stdin to be
seen as a terminal even though it is actually a file or pipe.

Regarding --short_socket_read then currently this does not work, as available
does not take the --short_socket_read flag into account.

https://codereview.chromium.org/17463003/diff/5001/runtime/bin/socket_patch.dart
File runtime/bin/socket_patch.dart (right):

https://codereview.chromium.org/17463003/diff/5001/runtime/bin/socket_patch.d...
runtime/bin/socket_patch.dart:1030: if (Platform.operatingSystem == "macos") {
On 2013/06/20 12:10:48, Anders Johnsen wrote:
> Platform.isMacos :)

Done (that was actually why I added isMacOS to Platform).

[Anders Johnsen, 2013-06-25 10:33:54]

LGTM, while I'm not that happy about platform-specific code in Dart, I agree
that this is the least intruding way of doing it.

[Søren Gjesse, 2013-06-25 11:48:03]

Committed patchset #5 manually as r24397 (presubmit successful).