Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(19)

Issue 17453003: Fixing an issue where EXTDrawBuffers.drawBuffersEXT was not getting generated. (Closed)

Created:
7 years, 6 months ago by blois
Modified:
7 years, 6 months ago
Reviewers:
vsm
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Fixing an issue where EXTDrawBuffers.drawBuffersEXT was not getting generated. Core issue is that sequences of typedefs aren't getting resolved properly, so it was treated as an unknown type. Did a workaround, opened bug 11395 to track the core IDL parser issue. BUG=11029 R=vsm@google.com Committed: https://code.google.com/p/dart/source/detail?r=24296

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -3 lines) Patch
M sdk/lib/web_gl/dart2js/web_gl_dart2js.dart View 1 chunk +6 lines, -0 lines 0 comments Download
M sdk/lib/web_gl/dartium/web_gl_dartium.dart View 1 chunk +5 lines, -0 lines 0 comments Download
M tools/dom/dom.json View 2 chunks +3 lines, -2 lines 0 comments Download
M tools/dom/scripts/dartgenerator.py View 1 chunk +4 lines, -1 line 0 comments Download
M tools/dom/scripts/generator.py View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
blois
7 years, 6 months ago (2013-06-20 19:57:24 UTC) #1
vsm
lgtm
7 years, 6 months ago (2013-06-21 01:10:49 UTC) #2
blois
7 years, 6 months ago (2013-06-21 17:34:27 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r24296 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698