Also remove Library/Safari from users home dir if --clear_safari_cache is set

Also remove Library/Safari from users home dir if --clear_safari_cache is set

Additionally, actually handle errors on deletion correctly by checking for existense first and actually failing if we fail to delete the directory.

R=kustermann@google.com

Committed: https://code.google.com/p/dart/source/detail?r=24238

[kustermann, 2013-06-20 15:54:11]

lgtm

https://codereview.chromium.org/17450017/diff/2001/tools/testing/dart/browser...
File tools/testing/dart/browser_controller.dart (right):

https://codereview.chromium.org/17450017/diff/2001/tools/testing/dart/browser...
tools/testing/dart/browser_controller.dart:219: _logEvent("Failure trying to
delete $paths.current");
'$paths.current' -> '${paths.current}'
print error as well or: 'error' -> '_'

https://codereview.chromium.org/17450017/diff/2001/tools/testing/dart/browser...
tools/testing/dart/browser_controller.dart:234: void addHome(dir) =>
"$home/$dir";
addHome seems to be unused

[ricow1, 2013-06-20 15:59:04]

https://codereview.chromium.org/17450017/diff/2001/tools/testing/dart/browser...
File tools/testing/dart/browser_controller.dart (right):

https://codereview.chromium.org/17450017/diff/2001/tools/testing/dart/browser...
tools/testing/dart/browser_controller.dart:219: _logEvent("Failure trying to
delete $paths.current");
On 2013/06/20 15:54:11, kustermann wrote:
> '$paths.current' -> '${paths.current}'
> print error as well or: 'error' -> '_'

Done.

https://codereview.chromium.org/17450017/diff/2001/tools/testing/dart/browser...
tools/testing/dart/browser_controller.dart:234: void addHome(dir) =>
"$home/$dir";
On 2013/06/20 15:54:11, kustermann wrote:
> addHome seems to be unused

Done.

[ricow1, 2013-06-20 16:01:47]

Committed patchset #3 manually as r24238 (presubmit successful).