Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(20)

Issue 17450005: Include named parameters in reflection names. (Closed)

Created:
7 years, 6 months ago by ahe
Modified:
7 years, 6 months ago
Reviewers:
kasperl
CC:
reviews_dartlang.org, ngeoffray, kasperl, Johnni Winther, karlklose
Visibility:
Public.

Description

Include named parameters in reflection names. BUG=http://dartbug.com/9283 R=kasperl@google.com Committed: https://code.google.com/p/dart/source/detail?r=24278

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -6 lines) Patch
M dart/sdk/lib/_internal/compiler/implementation/js_backend/emitter.dart View 2 chunks +23 lines, -2 lines 0 comments Download
M dart/tests/lib/mirrors/get_symbol_name_no_such_method_test.dart View 1 chunk +2 lines, -4 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
ahe
Should be able to close http://dartbug.com/9283 when this lands.
7 years, 6 months ago (2013-06-19 14:56:39 UTC) #1
kasperl
LGTM!
7 years, 6 months ago (2013-06-20 07:06:11 UTC) #2
ahe
7 years, 6 months ago (2013-06-21 10:34:55 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r24278 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698