Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(118)

Issue 17447003: Correctly type check type variable expressions. (Closed)

Created:
7 years, 6 months ago by Johnni Winther
Modified:
7 years, 6 months ago
Reviewers:
karlklose
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Correctly type check type variable expressions. BUG= R=karlklose@google.com Committed: https://code.google.com/p/dart/source/detail?r=24177

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+41 lines, -12 lines) Patch
M sdk/lib/_internal/compiler/implementation/resolution/members.dart View 2 chunks +4 lines, -1 line 0 comments Download
M sdk/lib/_internal/compiler/implementation/typechecker.dart View 3 chunks +14 lines, -10 lines 0 comments Download
M sdk/lib/_internal/compiler/implementation/warnings.dart View 1 chunk +2 lines, -0 lines 0 comments Download
M tests/compiler/dart2js/type_checker_test.dart View 2 chunks +21 lines, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
Johnni Winther
7 years, 6 months ago (2013-06-19 08:05:48 UTC) #1
karlklose
LGTM.
7 years, 6 months ago (2013-06-19 09:28:39 UTC) #2
Johnni Winther
7 years, 6 months ago (2013-06-19 09:57:30 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r24177 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698