Issue 174393004: Add Dart_GetNativeFieldsOfArgument to get all the native fields of a dart

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 174393004: Add Dart_GetNativeFieldsOfArgument to get all the native fields of a dart (Closed)

Created:
6 years, 10 months ago by siva

Modified:
6 years, 10 months ago

Reviewers:
vsm, rmacnak

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Add Dart_GetNativeFieldsOfArgument to get all the native fields of a dart object. This is especially useful for dartium which has two native fields the type id and the native implementation field for the wrapper. This allows for both values to be extracted in one call. R=vsm@google.com Committed: https://code.google.com/p/dart/source/detail?r=32905

Patch Set 1 #

Total comments: 2

Created: 6 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+147 lines, -25 lines)			Patch
M	runtime/include/dart_api.h	View	1 chunk	+15 lines, -5 lines	2 comments	Download
M	runtime/vm/dart_api_impl.cc	View	2 chunks	+23 lines, -18 lines	0 comments	Download
M	runtime/vm/dart_api_impl_test.cc	View	1 chunk	+81 lines, -0 lines	0 comments	Download
M	runtime/vm/object.h	View	3 chunks	+28 lines, -2 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

vsm

lgtm https://codereview.chromium.org/174393004/diff/1/runtime/include/dart_api.h File runtime/include/dart_api.h (right): https://codereview.chromium.org/174393004/diff/1/runtime/include/dart_api.h#newcode2100 runtime/include/dart_api.h:2100: * returnds an error handle. On success the ...

6 years, 10 months ago (2014-02-21 16:19:04 UTC) #2

siva

Committed patchset #1 manually as r32905 (presubmit successful).

6 years, 10 months ago (2014-02-21 16:53:27 UTC) #3

siva

6 years, 10 months ago (2014-02-21 19:01:09 UTC) #4

Message was sent while issue was closed.

https://codereview.chromium.org/174393004/diff/1/runtime/include/dart_api.h
File runtime/include/dart_api.h (right):

https://codereview.chromium.org/174393004/diff/1/runtime/include/dart_api.h#n...
runtime/include/dart_api.h:2100: *   returnds an error handle. On success the
native field values are copied
On 2014/02/21 16:19:04, vsm wrote:
> returnds -> returns

Done.

Expand Messages | Collapse Messages