Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(338)

Issue 17434008: Move PathObserver to mdv_observe package (Closed)

Created:
7 years, 6 months ago by Jennifer Messerly
Modified:
7 years, 6 months ago
Reviewers:
justinfagnani, blois
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Move PathObserver to mdv_observe package (Since it doesn't actually depend on dart:html, didn't seem the right place for it) R=blois@google.com Committed: https://code.google.com/p/dart/source/detail?r=24166

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -1124 lines) Patch
A + pkg/mdv_observe/test/path_observer_test.dart View 2 chunks +0 lines, -3 lines 0 comments Download
M sdk/lib/html/dart2js/html_dart2js.dart View 1 chunk +0 lines, -287 lines 0 comments Download
M sdk/lib/html/dartium/html_dartium.dart View 1 chunk +0 lines, -287 lines 0 comments Download
M sdk/lib/mdv_observe_impl/mdv_observe_impl.dart View 1 chunk +2 lines, -0 lines 0 comments Download
A + sdk/lib/mdv_observe_impl/path_observer.dart View 2 chunks +1 line, -2 lines 0 comments Download
D tests/html/path_observer_test.dart View 1 chunk +0 lines, -255 lines 0 comments Download
D tools/dom/src/PathObserver.dart View 1 chunk +0 lines, -288 lines 0 comments Download
M tools/dom/templates/html/dart2js/html_dart2js.darttemplate View 1 chunk +0 lines, -1 line 0 comments Download
M tools/dom/templates/html/dartium/html_dartium.darttemplate View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
Jennifer Messerly
7 years, 6 months ago (2013-06-19 01:25:53 UTC) #1
blois
lgtm
7 years, 6 months ago (2013-06-19 01:32:27 UTC) #2
Jennifer Messerly
7 years, 6 months ago (2013-06-19 02:22:03 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r24166 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698