Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(499)

Issue 174313004: Fixing non-posix path issue on Window (Closed)

Created:
6 years, 10 months ago by blois
Modified:
6 years, 10 months ago
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Fixing non-posix path issue on Window The code dealing with paths in Resolver should always use URI paths, but was instead using native path syntax in a few places. BUG= R=sigmund@google.com Committed: https://code.google.com/p/dart/source/detail?r=32972

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -9 lines) Patch
M pkg/code_transformers/lib/src/resolver_impl.dart View 2 chunks +8 lines, -6 lines 0 comments Download
M pkg/pkg.status View 1 chunk +0 lines, -3 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
blois
6 years, 10 months ago (2014-02-21 22:28:09 UTC) #1
Siggi Cherem (dart-lang)
lgtm
6 years, 10 months ago (2014-02-21 22:45:02 UTC) #2
blois
6 years, 10 months ago (2014-02-24 17:15:08 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r32972 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698