Issue 17422004: ClassMirror.newInstance in minified mode.

Issue 17422004: ClassMirror.newInstance in minified mode. (Closed)

Created:
7 years, 6 months ago by ahe

Modified:
7 years, 6 months ago

Reviewers:
ngeoffray

CC:
reviews_dartlang.org, kasperl, ngeoffray, karlklose, Johnni Winther

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

ClassMirror.newInstance in minified mode. R=ngeoffray@google.com Committed: https://code.google.com/p/dart/source/detail?r=24169

Patch Set 2 : Address comments #

Patch Set 3 : Merged and updated lib.status #

Created: 7 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+53 lines, -12 lines)			Patch
M	dart/sdk/lib/_internal/compiler/implementation/js_backend/emitter.dart	View	1	6 chunks	+19 lines, -5 lines	0 comments	Download
M	dart/sdk/lib/_internal/lib/js_mirrors.dart	View		3 chunks	+34 lines, -3 lines	0 comments	Download
M	dart/tests/lib/lib.status	View	1 2	1 chunk	+0 lines, -3 lines	0 comments	Download
M	dart/tests/lib/mirrors/mirrors_test.dart	View		1 chunk	+0 lines, -1 line	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

ngeoffray

LGTM https://codereview.chromium.org/17422004/diff/1/dart/sdk/lib/_internal/compiler/implementation/js_backend/emitter.dart File dart/sdk/lib/_internal/compiler/implementation/js_backend/emitter.dart (right): https://codereview.chromium.org/17422004/diff/1/dart/sdk/lib/_internal/compiler/implementation/js_backend/emitter.dart#newcode1657 dart/sdk/lib/_internal/compiler/implementation/js_backend/emitter.dart:1657: buffer.write(',$n$n"+${classElement.name.slowToString()}": 0'); Unconditionally? So you're adding this extra ...

7 years, 6 months ago (2013-06-19 06:26:36 UTC) #2

ahe

https://codereview.chromium.org/17422004/diff/1/dart/sdk/lib/_internal/compiler/implementation/js_backend/emitter.dart File dart/sdk/lib/_internal/compiler/implementation/js_backend/emitter.dart (right): https://codereview.chromium.org/17422004/diff/1/dart/sdk/lib/_internal/compiler/implementation/js_backend/emitter.dart#newcode1657 dart/sdk/lib/_internal/compiler/implementation/js_backend/emitter.dart:1657: buffer.write(',$n$n"+${classElement.name.slowToString()}": 0'); On 2013/06/19 06:26:36, ngeoffray wrote: > Unconditionally? ...

7 years, 6 months ago (2013-06-19 07:20:29 UTC) #3

ahe

7 years, 6 months ago (2013-06-19 07:47:54 UTC) #4

Message was sent while issue was closed.

Committed patchset #3 manually as r24169 (presubmit successful).

Expand Messages | Collapse Messages