Issue 174213002: Rework Sample class

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 174213002: Rework Sample class (Closed)

Created:
6 years, 10 months ago by Cutch

Modified:
6 years, 10 months ago

Reviewers:
siva

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Rework Sample class BUG= R=asiva@google.com Committed: https://code.google.com/p/dart/source/detail?r=32870

Patch Set 2 : #

Total comments: 1

Created: 6 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+127 lines, -187 lines)			Patch
M	runtime/vm/profiler.h	View	2 chunks	+90 lines, -47 lines	1 comment	Download
M	runtime/vm/profiler.cc	View	5 chunks	+27 lines, -126 lines	0 comments	Download
M	runtime/vm/profiler_test.cc	View	4 chunks	+10 lines, -14 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

siva

lgtm https://codereview.chromium.org/174213002/diff/40001/runtime/vm/profiler.h File runtime/vm/profiler.h (right): https://codereview.chromium.org/174213002/diff/40001/runtime/vm/profiler.h#newcode113 runtime/vm/profiler.h:113: pcs_[i] = 0; I am wondering if we ...

6 years, 10 months ago (2014-02-20 21:07:38 UTC) #2

Cutch

Committed patchset #2 manually as r32870 (presubmit successful).

6 years, 10 months ago (2014-02-20 21:10:13 UTC) #3

Cutch

6 years, 10 months ago (2014-02-20 21:11:33 UTC) #4

Message was sent while issue was closed.

On 2014/02/20 21:07:38, siva wrote:
> lgtm
> 
> https://codereview.chromium.org/174213002/diff/40001/runtime/vm/profiler.h
> File runtime/vm/profiler.h (right):
> 
>
https://codereview.chromium.org/174213002/diff/40001/runtime/vm/profiler.h#ne...
> runtime/vm/profiler.h:113: pcs_[i] = 0;
> I am wondering if we should initialize it to kZapUninitializedWord
> instead of 0 to make the unused slots more apparent.

I'm relying on the zero to indicate the end of the stack trace. We could fill
with kZapUninitializedWord and then change the stack walking code to write a 0
in the final frame. I'll commit this for now.

Expand Messages | Collapse Messages

Issue 174213002: Rework Sample class (Closed)

Description

Patch Set 1 #

Patch Set 2 : #

Messages